Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] avformat/mov: don't unnecesarely replace extradata with the same one
@ 2025-07-31 15:34 James Almer
  0 siblings, 0 replies; only message in thread
From: James Almer @ 2025-07-31 15:34 UTC (permalink / raw)
  To: ffmpeg-devel

If the first STSC entry refers to the first extradata buffer, then don't
bother replacing the output stream's extradata as it's already set to it.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/mov.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/mov.c b/libavformat/mov.c
index 7f88ec8220..a3e1aa2933 100644
--- a/libavformat/mov.c
+++ b/libavformat/mov.c
@@ -10667,7 +10667,7 @@ static int mov_read_header(AVFormatContext *s)
         fix_timescale(mov, sc);
 
         /* Set the primary extradata based on the first Sample. */
-        if (sc->stsc_count && sc->extradata_size && !sc->iamf) {
+        if (sc->stsc_count && sc->extradata_size && sc->stsc_data[0].id != 1 && !sc->iamf) {
             sc->last_stsd_index = sc->stsc_data[0].id - 1;
             av_freep(&st->codecpar->extradata);
             st->codecpar->extradata_size = sc->extradata_size[sc->last_stsd_index];
-- 
2.50.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-07-31 15:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-31 15:34 [FFmpeg-devel] [PATCH] avformat/mov: don't unnecesarely replace extradata with the same one James Almer

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git