From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
Subject: Re: [FFmpeg-devel] Revert "avformat/tls_openssl: properly get new BIO index"
Date: Wed, 30 Jul 2025 20:53:49 +0200
Message-ID: <20250730205349.GB152101@haasn.xyz> (raw)
In-Reply-To: <aIpb-1M5yW3rrs5-@phare.normalesup.org>
On Wed, 30 Jul 2025 19:52:59 +0200 Nicolas George <george@nsup.org> wrote:
> Kacper Michajłow (HE12025-07-30):
> > > Note that BIO_get_new_index() can only be used 127 times before it
> > > returns an error.
> >
> > We cannot call it repeatedly, because it will fail eventually.
> >
> > To my understanding the index is not needed in our use and we could
> > safely use BIO_TYPE_NONE. Documentation states:
> >
> > > type can be set to either BIO_TYPE_NONE or via BIO_get_new_index() if
> > > a unique type is required for searching (See BIO_find_type(3))
> >
> > We don't use any search related functions.
>
> This should never have reached the commit message.
I disagree. Without this important context, the motivation behind the
change is much less clear.
>
> --
> Nicolas George
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-07-30 18:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20250730174635.C39D4412998@natalya.videolan.org>
2025-07-30 17:52 ` Nicolas George
2025-07-30 18:34 ` Kacper Michajlow
2025-07-30 18:53 ` Niklas Haas [this message]
2025-07-30 19:53 ` Nicolas George
2025-07-30 21:03 ` Kacper Michajlow
2025-07-30 21:39 ` Nicolas George
2025-07-30 21:59 ` Niklas Haas
2025-07-30 22:02 ` Nicolas George
2025-07-30 23:00 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250730205349.GB152101@haasn.xyz \
--to=ffmpeg@haasn.xyz \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git