From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 157DD4C184 for ; Wed, 30 Jul 2025 10:01:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3B0AC68C356; Wed, 30 Jul 2025 13:01:47 +0300 (EEST) Received: from relay15.mail.gandi.net (relay15.mail.gandi.net [217.70.178.235]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 4A27D687AF3 for ; Wed, 30 Jul 2025 13:01:40 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 7679E4317F for ; Wed, 30 Jul 2025 10:01:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1753869699; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WAKHr5Z0l9vrtli911tw2JdC9TqCvIam6sTUaOBuKQQ=; b=Zhb2dcxwaD1+eCHcBWBtTjfMqD4BgvCUlW3a05dYneaPW5QgQUhz+kTvEV4E7j3pSrYW2b pvjxuinRmh+O7z0VtK7/jgX4KlRkDqFDLTBj6hOPizq5oJOAeU/N0eukoWnuZ3E99SaLPC Yz+JMSUuf5VbGWidLngspht+a1KhB0Q3RPlpupmkG/SRWSK0f9CzPPA1WT109rveHOgcPK DPfvGjvARHbHA86f4HEjK23EDwyi0aBnPg/uZustLU19rYorx2+rDRDB5d0li1vQejHJoH r49PoMIDxclSK3G88n+1k/L8h8u6wH/Au5Ni4G7n/mUYE9GKdLVu519kXLTZPA== Date: Wed, 30 Jul 2025 12:01:38 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250730100138.GP29660@pb2> References: MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -41 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdeljeeigecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegoufhushhpvggtthffohhmrghinhculdegledmnegfrhhlucfvnfffucdluddtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepjeelgedvkefhlefhteeljeegteekvdehhfdufeevjeeiffejkeekuedtjeegvddtnecuffhomhgrihhnpegtrhgsuhhgrdgtohhmnecukfhppeeguddrieeirdeihedrudejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeihedrudejiedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh Subject: Re: [FFmpeg-devel] [flac] Fix integer-overflow in flac_lpc_33_c X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8593270011985344147==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8593270011985344147== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="gT7MEax6dFiiQEXU" Content-Disposition: inline --gT7MEax6dFiiQEXU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Dale On Tue, Jul 29, 2025 at 03:07:38PM -0700, Dale Curtis wrote: > This fix copies a couple of casts from surrounding functions. > See https://crbug.com/432528781 for stack trace details. >=20 > Signed-off-by: Dale Curtis > flacdsp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > 187b2fdeaecb08d3683b90875f4d7c0e74a38da1 flac_fix_v1.patch > From 0bf245bf8a031d12aec77e68dbc627247255eeb0 Mon Sep 17 00:00:00 2001 > From: Dale Curtis > Date: Tue, 29 Jul 2025 22:05:19 +0000 > Subject: [PATCH] [flac] Fix integer-overflow in flac_lpc_33_c >=20 > This fix copies a couple of casts from surrounding functions. > See https://crbug.com/432528781 for stack trace details. You (email=3Dmichael@niedermayer.cc) are not authorized to access this page! [...] > - decoded[j] =3D residual[i] + (sum >> qlevel); > + decoded[j] =3D (uint64_t)residual[i] + (unsigned)(sum >> qlevel); This does not give the same result for cases that do not overflow I would guess more in the direction of: decoded[j] =3D (int64_t)residual[i] + (uint64_t)(sum >> qlevel); thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB During times of universal deceit, telling the truth becomes a revolutionary act. -- George Orwell --gT7MEax6dFiiQEXU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaIntfQAKCRBhHseHBAsP q1H+AJ9FSqXHjE3wjSGePRAFWnUaxlIjcACcDUnlTSawMveINKcQE5v9oJQHKhI= =Y4CE -----END PGP SIGNATURE----- --gT7MEax6dFiiQEXU-- --===============8593270011985344147== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8593270011985344147==--