From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 87C634C009 for ; Mon, 28 Jul 2025 15:50:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 150CA68D203; Mon, 28 Jul 2025 18:50:20 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 1D18A68C3DD for ; Mon, 28 Jul 2025 18:50:13 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 781B3444EB for ; Mon, 28 Jul 2025 15:50:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1753717812; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7bJ34Hg5G3bNn1Svv4Hcb2snEqs4caHIR+n14HvJ4XY=; b=TqVdOpBpaaeeGhnvFFVF3g83XuXkvZYNUdww0qImd1H/bCBPW5T5dhmxQIHHmG3BBSz102 H0xPESV+qAPMAfZpBxOngPOe6cu4/0UdCFzk36WYSgPuu9nMD+c1//xYHOAGvro0wTGxt5 vXGGdtijY7Ut49oy5sraItSVszoOTbwRSpbjpQ/atvzBMN9Nr/HUFOINwP0SMw5suuUbDu vYjzVMrGTIzmaGo/7h4laaAL4YMkJmcH8CZF8tCI35ZRxHAd9Y03TXcq8gC0OPLDL3wgVD ECLUBxoHdzckYx2hF26OZPIf+3IaaRVuQiQAEoiSv1FzcNurZzjcnTOM1OKYfg== Date: Mon, 28 Jul 2025 17:50:11 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250728155011.GF29660@pb2> References: <20250723114540.151693-1-michael@niedermayer.cc> <20250723114540.151693-3-michael@niedermayer.cc> <8fd6c292856b2cb7f91b7bf7648b44d985c29d50.camel@haerdin.se> <876dd4b6fbdaf7f38886ea6c4b671462207a3ebf.camel@haerdin.se> MIME-Version: 1.0 In-Reply-To: <876dd4b6fbdaf7f38886ea6c4b671462207a3ebf.camel@haerdin.se> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdelvdehjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtudenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepjeetfeduudefgeevjeffheeihfegudekvefgfeekgeejgfeiieetleeuieevgeeunecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepgedurdeiiedrieehrddujeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieehrddujeeipdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 3/4] avformat/mxfdec: Ensure klv->key is initialized X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5706124973946333905==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5706124973946333905== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="GBq9KTDOxLof+MVq" Content-Disposition: inline --GBq9KTDOxLof+MVq Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jul 24, 2025 at 08:25:35PM +0200, Tomas H=E4rdin wrote: > tor 2025-07-24 klockan 00:51 +0200 skrev Marton Balint: > >=20 > >=20 > > On Wed, 23 Jul 2025, Tomas H=E4rdin wrote: > >=20 > > > ons 2025-07-23 klockan 13:45 +0200 skrev Michael Niedermayer: > > > > Fixes: read of uninitialized memory > > > > Fixes: 391916474/clusterfuzz-testcase-minimized- > > > > ffmpeg_dem_MXF_fuzzer-4935250956845056 > > > >=20 > > > > Found-by: continuous fuzzing process > > > > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > > > > Signed-off-by: Michael Niedermayer > > > > --- > > > > =A0libavformat/mxfdec.c | 4 +++- > > > > =A01 file changed, 3 insertions(+), 1 deletion(-) > > > >=20 > > > > diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c > > > > index 0eed13d850d..184e97256cd 100644 > > > > --- a/libavformat/mxfdec.c > > > > +++ b/libavformat/mxfdec.c > > > > @@ -491,7 +491,9 @@ static int klv_read_packet(MXFContext *mxf, > > > > KLVPacket *klv, AVIOContext *pb) > > > > =A0=A0=A0=A0=A0=A0=A0=A0 return AVERROR_INVALIDDATA; > > > > =A0 > > > > =A0=A0=A0=A0 memcpy(klv->key, mxf_klv_key, 4); > > > > -=A0=A0=A0 avio_read(pb, klv->key + 4, 12); > > > > +=A0=A0=A0 int ret =3D ffio_read_size(pb, klv->key + 4, 12); > > > > +=A0=A0=A0 if (ret < 0) > > > > +=A0=A0=A0=A0=A0=A0=A0 return ret; > > >=20 > > > ret !=3D 12 is better. If it's non-negative then return AVERROR_EOF > >=20 > > ffio_read_size always returns the requested size or negative. >=20 > Herp. Well in that case it's fine yes will apply patchset thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Any man who breaks a law that conscience tells him is unjust and willingly= =20 accepts the penalty by staying in jail in order to arouse the conscience of= =20 the community on the injustice of the law is at that moment expressing the= =20 very highest respect for law. - Martin Luther King Jr --GBq9KTDOxLof+MVq Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaIecMAAKCRBhHseHBAsP q2onAJ4uTJeN2QxgMrWg0fu10hA0JJPQlQCaA7HERR4L7eiCbSOaC2HtTPhUNtQ= =PWre -----END PGP SIGNATURE----- --GBq9KTDOxLof+MVq-- --===============5706124973946333905== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5706124973946333905==--