From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id CB1474C000 for ; Mon, 28 Jul 2025 15:40:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id EFF1868D1C1; Mon, 28 Jul 2025 18:40:05 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id B746768CF0A for ; Mon, 28 Jul 2025 18:39:58 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 04FFC1FD45 for ; Mon, 28 Jul 2025 15:39:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1753717198; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VdCcQtB0dKLHVqKeeNSu6JByZr+ru0olhiNaD73ccdA=; b=eZw1cgMooQ8dF7ONhY6/Ca/+lPWxbwJWyvYrQX1S+BAOwJ+l4xX69vMYSo+sydO8RlVUIT QXMSxMPk7r9kQTQXvr+868iKwPYTdbf+CjdyEc9cyGaSsyqiILGc5JtCLylC8sXDdSIVCa Zj9Os+PpsuMQOREia/URL3Tk4MMGjDa6ayeb4owb+J2Au1JHihh4jmdXfLwDfgAUBE8tpp 1aYcTkbOeMrnTNWDCxfuF7Pv/3ySICQNMvt2PS7sfHmst7ZOYy+xnfZQdnsjVPwmrlydQV YewE2+hSZNQULuNQH6qtJD9ppUuimKyA8uHk/K2axx8dzmbb/Bd3D7pj7KfCew== Date: Mon, 28 Jul 2025 17:39:57 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250728153957.GE29660@pb2> References: <20250723084332.3650349-1-michael@niedermayer.cc> <20250727205713.GV29660@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdelvdehhecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepfeetffetheehtdevjeffleelteefjeeugeeiheekhfefudehkedtkedufeeuveelnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepgedurdeiiedrieehrddujeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieehrddujeeipdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/asfdec_f: Check amount of value read X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============4263507404539057426==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============4263507404539057426== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tIetTmXJQWRPh2gh" Content-Disposition: inline --tIetTmXJQWRPh2gh Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 28, 2025 at 01:10:57AM +0200, Kacper Michajlow wrote: > On Sun, 27 Jul 2025 at 22:57, Michael Niedermayer > wrote: > > > > On Wed, Jul 23, 2025 at 05:51:35PM +0200, Kacper Michajlow wrote: > > > On Wed, 23 Jul 2025 at 10:43, Michael Niedermayer > > > wrote: > > > > > > > > Fixes: use of uninitialized memory > > > > Fixes: 403675492/clusterfuzz-testcase-minimized-ffmpeg_dem_ASF_fuzz= er-4754281823797248 > > > > > > > > Found-by: continuous fuzzing process https://github.com/google/oss-= fuzz/tree/master/projects/ffmpeg > > > > Signed-off-by: Michael Niedermayer > > > > --- > > > > libavformat/asfdec_f.c | 4 +++- > > > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > > > > > diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c > > > > index ea6e8ef4f3a..10f5dea57c3 100644 > > > > --- a/libavformat/asfdec_f.c > > > > +++ b/libavformat/asfdec_f.c > > > > @@ -241,7 +241,9 @@ static void get_tag(AVFormatContext *s, const c= har *key, int type, int len, int > > > > avio_get_str16le(s->pb, len, value, 2 * len + 1); > > > > break; > > > > case -1: // ASCI > > > > - avio_read(s->pb, value, len); > > > > + ;int ret =3D ffio_read_size(s->pb, value, len); > > > > > > stray ; > > > > no, try remove it :) > > > > libavformat/asfdec_f.c: In function =E2=80=98get_tag=E2=80=99: > > libavformat/asfdec_f.c:244:9: error: a label can only be part of a stat= ement and a declaration is not a statement > > 244 | int ret =3D ffio_read_size(s->pb, value, len); > > | ^~~ >=20 > Ah, right. It's the first line after the case statement. >=20 > I generally put it immediately after : `case -1:;`. It was looking off > at the beginning of the line, but all good :) ill move to after the : thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The misfortune of the wise is better than the prosperity of the fool. -- Epicurus --tIetTmXJQWRPh2gh Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaIeZzAAKCRBhHseHBAsP q/g+AJwKgwawaDAuSjQZaDGv7cspSV3cnwCgifst4cfxIHRAOJGhBjiwuceHqY8= =+GQc -----END PGP SIGNATURE----- --tIetTmXJQWRPh2gh-- --===============4263507404539057426== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============4263507404539057426==--