Re: [FFmpeg-devel] [PATCH] checkasm/h264dsp: Fix stack-buffer-overflow, effective-type violations

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1378 bytes --]

Hi Marvin

On Fri, Jul 11, 2025 at 05:34:48PM +0200, Marvin Scholz wrote:
> 
> 
> On 25 Jun 2025, at 23:39, Tristan Matthews via ffmpeg-devel wrote:
> 
> > On Monday, June 16th, 2025 at 2:22 PM, Andreas Rheinhardt <andreas.rheinhardt@outlook.com> wrote:
> >
> > Tristan Matthews via ffmpeg-devel:
> >
> > On Monday, June 16th, 2025 at 6:53 AM, Andreas Rheinhardt andreas.rheinhardt@outlook.com wrote:
> >
> > Patch attached.
> >
> > LGTM, and sorry about that, for future reference did you do anything in particular (instrumentation wise) to catch the stack overflow? I tried make fate on a few different machines and didn't hit that.
> >
> > Best,
> > Tristan
> >
> >
> > I used (Clang) ASAN. Presumably Zhao Zhili (who first reported the stack
> > buffer overflow) did so, too.
> >
> > - Andreas
> >
> >
> > It'd be good to merge either this or Zhao Zhili's patch to get checkasm back to being ASAN clean.
> >
> > Best,
> > Tristan
> 
> If there are no objections, I would like to merge this patch soon.

there where no objections, this is still broken, i just run into it
again.

please apply

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".