* [FFmpeg-devel] [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated
@ 2025-07-28 3:45 Cai Fan
2025-07-28 9:51 ` Steven Liu
0 siblings, 1 reply; 4+ messages in thread
From: Cai Fan @ 2025-07-28 3:45 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Cai Fan
Signed-off-by: Cai Fan <caifan0425@163.com>
---
libavformat/img2enc.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c
index 41638d92b8..672cfe18fd 100644
--- a/libavformat/img2enc.c
+++ b/libavformat/img2enc.c
@@ -180,6 +180,10 @@ static int write_packet(AVFormatContext *s, AVPacket *pkt)
}
for (i = 0; i < 4; i++) {
av_dict_copy(&options, img->protocol_opts, 0);
+ if (strlen(filename) + 5 >= sizeof(img->tmp[i])) {
+ av_log(s, AV_LOG_ERROR, "Filename too long: %s\n", filename);
+ return AVERROR(EINVAL);
+ }
snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename);
av_strlcpy(img->target[i], filename, sizeof(img->target[i]));
if (s->io_open(s, &pb[i], img->use_rename ? img->tmp[i] : filename, AVIO_FLAG_WRITE, &options) < 0) {
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated
2025-07-28 3:45 [FFmpeg-devel] [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated Cai Fan
@ 2025-07-28 9:51 ` Steven Liu
0 siblings, 0 replies; 4+ messages in thread
From: Steven Liu @ 2025-07-28 9:51 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Cai Fan
Cai Fan <caifan0425@163.com> 于2025年7月28日周一 11:45写道：
>
> Signed-off-by: Cai Fan <caifan0425@163.com>
> ---
> libavformat/img2enc.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c
> index 41638d92b8..672cfe18fd 100644
> --- a/libavformat/img2enc.c
> +++ b/libavformat/img2enc.c
> @@ -180,6 +180,10 @@ static int write_packet(AVFormatContext *s, AVPacket *pkt)
> }
> for (i = 0; i < 4; i++) {
> av_dict_copy(&options, img->protocol_opts, 0);
> + if (strlen(filename) + 5 >= sizeof(img->tmp[i])) {
> + av_log(s, AV_LOG_ERROR, "Filename too long: %s\n", filename);
> + return AVERROR(EINVAL);
need free options.
should ret = AVERROR(EINVAL);
and goto fail:
> + }
> snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename);
> av_strlcpy(img->target[i], filename, sizeof(img->target[i]));
> if (s->io_open(s, &pb[i], img->use_rename ? img->tmp[i] : filename, AVIO_FLAG_WRITE, &options) < 0) {
> --
> 2.34.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [FFmpeg-devel] [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated
2025-07-29 2:23 Cai Fan
@ 2025-07-29 9:40 ` Steven Liu
0 siblings, 0 replies; 4+ messages in thread
From: Steven Liu @ 2025-07-29 9:40 UTC (permalink / raw)
To: FFmpeg development discussions and patches; +Cc: Cai Fan
Cai Fan <caifan0425@163.com> 于2025年7月29日周二 10:23写道：
>
> Signed-off-by: Cai Fan <caifan0425@163.com>
> ---
> libavformat/img2enc.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c
> index 672cfe18fd..f7d983ec54 100644
> --- a/libavformat/img2enc.c
> +++ b/libavformat/img2enc.c
> @@ -182,7 +182,8 @@ static int write_packet(AVFormatContext *s, AVPacket *pkt)
> av_dict_copy(&options, img->protocol_opts, 0);
> if (strlen(filename) + 5 >= sizeof(img->tmp[i])) {
> av_log(s, AV_LOG_ERROR, "Filename too long: %s\n", filename);
> - return AVERROR(EINVAL);
> + ret = AVERROR(EINVAL);
> + goto fail;
perhaps you should make patch base on the ffmpeg git master, don't
base on yourseves newest commit.
> }
> snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename);
> av_strlcpy(img->target[i], filename, sizeof(img->target[i]));
> --
> 2.34.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel@ffmpeg.org
> https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>
> To unsubscribe, visit link above, or email
> ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
* [FFmpeg-devel] [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated
@ 2025-07-29 2:23 Cai Fan
2025-07-29 9:40 ` Steven Liu
0 siblings, 1 reply; 4+ messages in thread
From: Cai Fan @ 2025-07-29 2:23 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Cai Fan
Signed-off-by: Cai Fan <caifan0425@163.com>
---
libavformat/img2enc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavformat/img2enc.c b/libavformat/img2enc.c
index 672cfe18fd..f7d983ec54 100644
--- a/libavformat/img2enc.c
+++ b/libavformat/img2enc.c
@@ -182,7 +182,8 @@ static int write_packet(AVFormatContext *s, AVPacket *pkt)
av_dict_copy(&options, img->protocol_opts, 0);
if (strlen(filename) + 5 >= sizeof(img->tmp[i])) {
av_log(s, AV_LOG_ERROR, "Filename too long: %s\n", filename);
- return AVERROR(EINVAL);
+ ret = AVERROR(EINVAL);
+ goto fail;
}
snprintf(img->tmp[i], sizeof(img->tmp[i]), "%s.tmp", filename);
av_strlcpy(img->target[i], filename, sizeof(img->target[i]));
--
2.34.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-07-29 9:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-28 3:45 [FFmpeg-devel] [PATCH 1/1] libavformat/img2enc.c: rm warning ‘.tmp’ directive output may be truncated Cai Fan
2025-07-28 9:51 ` Steven Liu
2025-07-29 2:23 Cai Fan
2025-07-29 9:40 ` Steven Liu
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git