From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 675304BF8C for ; Mon, 28 Jul 2025 00:22:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 8DE2B68D52C; Mon, 28 Jul 2025 03:22:20 +0300 (EEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 9EA3268D127 for ; Mon, 28 Jul 2025 03:22:13 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 0A48041C7C for ; Mon, 28 Jul 2025 00:22:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1753662133; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=mDbd70dfOPWZ10RnvGtzqZQLZolvBRADgFdEB9QTMK4=; b=HYncFlA9o4cnY7qKfomHiB2qiFo5IbGQ9+OmFjJyXAcKBmaVmtuj5B7RAJNTQUAbdPuKF4 r6t8wXmcbH+q3LjlFFsuvy2Bp2ioVcVgYz/gzQ4mPMZoHlHad6Ny3eNw2orfkZOL/ofCRl 60JhIrco1xIYxE6W3RZVCjUg/1OCzO6yrHVvxIqo2RmftQCnz7ZHVGO+0qDOU35pFttAdg 1PW//kLM3kY9Y/KMJfgXHdESHNbSHqHoVQMupIY85UyF5hVGC7WC9HK1QIQg6K6NsCOvIe 5/8k59nPZrWQu9jzbOp9ufozLjQwqK028AE0xbFyYr9FuTo0Cz1voRV9aNpNkg== Date: Mon, 28 Jul 2025 02:22:12 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250728002212.GX29660@pb2> References: <20250604165852.75087-1-romain.beauxis@gmail.com> <20250614225713.GP29660@pb2> <20250621215947.GY29660@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdeltdejudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtudenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepveeufeegfeduteeugffgiedvteetkefgudektdejueffveehgeeludelffdugfehnecuffhomhgrihhnpehffhhmphgvghdrohhrghenucfkphepgedurdeiiedrieehrddujeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieehrddujeeipdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============3862035938245638592==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============3862035938245638592== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="aMglPt1noGkvzVW3" Content-Disposition: inline --aMglPt1noGkvzVW3 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Romain On Wed, Jul 23, 2025 at 02:06:07PM -0500, Romain Beauxis wrote: > Le sam. 21 juin 2025 =E0 16:59, Michael Niedermayer > a =E9crit : > > > > On Sat, Jun 21, 2025 at 10:45:32AM +0200, Romain Beauxis wrote: > > > Le dim. 15 juin 2025 =E0 00:57, Michael Niedermayer > > > a =E9crit : > > > > > > > > On Wed, Jun 04, 2025 at 11:58:52AM -0500, Romain Beauxis wrote: > > > > > This is a redo of 574f634e49847e2225ee50013afebf0de03ef013 using a > flat > > > > > memory storage for the extradata. > > > > > > > > > > PR review comments addressed: > > > > > * Use flat memory bytestream > > > > > * Re-use existing xiph extradata layout > > > > > > > > > > --- > > > > > > > > > libavcodec/vorbisdec.c | 42 ++++++++--- > > > > > libavformat/oggparsevorbis.c | 83 > +++++++++++++++++++++- > > > > > > > > patches that change both libraries at the same time are suspect > > > > > > > > if one depends on changes in the other it needs > > > > minor API version bump and seperate patches so extension of > > > > API and use of it are properly tracked and testable > > > > > > If I remember well, according to Andreas Rheinhardt there's no need > > > for an API bump here since the patch is re-using existing extradata > > > bitstream structures. > > > > If there is really no API extension then the micro versions should be > bumped > > so a user knows if the specific version he uses has teh fix. > > Also it may be usefull in bugreports about ogg to know if its prior or > > after this change >=20 > Hi Michael, >=20 > I have created a PR on code.ffmpeg.org here: > https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20026 >=20 > Would you have a minute to have a look? I do not have time, ive made a dumb mistake in configuring my inbox so iam about a week behind with emails without realizing it. thats on top of release, security, and other things maybe someome else can look into this one replying here so noone waits for a review from me thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Any man who breaks a law that conscience tells him is unjust and willingly= =20 accepts the penalty by staying in jail in order to arouse the conscience of= =20 the community on the injustice of the law is at that moment expressing the= =20 very highest respect for law. - Martin Luther King Jr --aMglPt1noGkvzVW3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaIbCtAAKCRBhHseHBAsP q2nKAJ49kFkDM1Sj8bzpjsR9gbL/q8baOACcC/8IbSbUvSfw1urjVplJ2HplluE= =cIqz -----END PGP SIGNATURE----- --aMglPt1noGkvzVW3-- --===============3862035938245638592== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============3862035938245638592==--