From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 94D6B4BBA0 for ; Sun, 27 Jul 2025 20:57:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 43FF568CFAD; Sun, 27 Jul 2025 23:57:23 +0300 (EEST) Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id DBDDE68C41B for ; Sun, 27 Jul 2025 23:57:15 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 11838444FE for ; Sun, 27 Jul 2025 20:57:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1753649835; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Loz4pnRxHlOj5eM27OAVOWANnDNkjuiQXnf6Yf03DXQ=; b=DQ16ZGUgoIgpp4YjJIkVxfD7X4fo0urxm0WjDukMNtzC8/IOsWetqs4bGIYXPtugBgrkae /UW3alwoaKwJp5SzyDh+UcEVkutwL7fHkCrvklhDhqn1nIfJjNQiQIf2QvDClIavn03NFT JFOlWsQhEoaILgNcMD0uGIGVS3VNSJz/Vc/yNXXB0KXPGcJMXPvCN+Z8Asg2SIu45g7DPE 9GbpNkNLk4VweEn6EdYKKO1FinPQZVS5N4LWkmtRUzHKSgJsH+P6KK5QR1Q1+H3Kp1YCIn N1Tto+mAEtfub07gPyWDJHEXpRh4/6d9wd29K7G4O1rYQNorMRowmCXHk71EIw== Date: Sun, 27 Jul 2025 22:57:13 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250727205713.GV29660@pb2> References: <20250723084332.3650349-1-michael@niedermayer.cc> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdeltdeftdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtjeenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepfeetffetheehtdevjeffleelteefjeeugeeiheekhfefudehkedtkedufeeuveelnecuffhomhgrihhnpehgihhthhhusgdrtghomhenucfkphepgedurdeiiedrieehrddujeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieehrddujeeipdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/asfdec_f: Check amount of value read X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============5868452260029695916==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============5868452260029695916== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="3ChEjlKQG30qDPT4" Content-Disposition: inline --3ChEjlKQG30qDPT4 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jul 23, 2025 at 05:51:35PM +0200, Kacper Michajlow wrote: > On Wed, 23 Jul 2025 at 10:43, Michael Niedermayer > wrote: > > > > Fixes: use of uninitialized memory > > Fixes: 403675492/clusterfuzz-testcase-minimized-ffmpeg_dem_ASF_fuzzer-4= 754281823797248 > > > > Found-by: continuous fuzzing process https://github.com/google/oss-fuzz= /tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/asfdec_f.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c > > index ea6e8ef4f3a..10f5dea57c3 100644 > > --- a/libavformat/asfdec_f.c > > +++ b/libavformat/asfdec_f.c > > @@ -241,7 +241,9 @@ static void get_tag(AVFormatContext *s, const char = *key, int type, int len, int > > avio_get_str16le(s->pb, len, value, 2 * len + 1); > > break; > > case -1: // ASCI > > - avio_read(s->pb, value, len); > > + ;int ret =3D ffio_read_size(s->pb, value, len); >=20 > stray ; no, try remove it :) libavformat/asfdec_f.c: In function =E2=80=98get_tag=E2=80=99: libavformat/asfdec_f.c:244:9: error: a label can only be part of a statemen= t and a declaration is not a statement 244 | int ret =3D ffio_read_size(s->pb, value, len); | ^~~ thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The bravest are surely those who have the clearest vision of what is before them, glory and danger alike, and yet notwithstanding go out to meet it. -- Thucydides --3ChEjlKQG30qDPT4 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaIaSqQAKCRBhHseHBAsP q1GvAJ92JHL9h+f/VatTWJLHiWx22bf2xwCdGJoeYdZpZ8nz6mBJQGZdYQ2/2nQ= =Gujt -----END PGP SIGNATURE----- --3ChEjlKQG30qDPT4-- --===============5868452260029695916== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============5868452260029695916==--