From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id BE4544BD9D for ; Thu, 24 Jul 2025 11:19:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id B37C268D7A9; Thu, 24 Jul 2025 14:19:35 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 5FB5968D6D4 for ; Thu, 24 Jul 2025 14:19:29 +0300 (EEST) Received: from haasn.dev (unknown [10.30.1.1]) by haasn.dev (Postfix) with UTF8SMTP id 33887418EF for ; Thu, 24 Jul 2025 13:19:29 +0200 (CEST) Date: Thu, 24 Jul 2025 13:19:29 +0200 Message-ID: <20250724131929.GH95314@haasn.xyz> From: Niklas Haas To: FFmpeg development discussions and patches In-Reply-To: References: <20250723135626.1390296-1-ffmpeg@haasn.xyz> <20250723135626.1390296-4-ffmpeg@haasn.xyz> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH v2 03/18] avfilter/vf_showinfo: print alpha mode when relevant X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Wed, 23 Jul 2025 18:11:23 +0200 Kacper Michajlow wrote: > On Wed, 23 Jul 2025 at 15:57, Niklas Haas wrote: > > > > From: Niklas Haas > > > > --- > > libavfilter/vf_showinfo.c | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c > > index c706d00c96..b564d03a84 100644 > > --- a/libavfilter/vf_showinfo.c > > +++ b/libavfilter/vf_showinfo.c > > @@ -887,6 +887,14 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *frame) > > > > dump_color_property(ctx, frame); > > > > + if (desc->flags & AV_PIX_FMT_FLAG_ALPHA) { > > + const char *alpha_mode_str = av_alpha_mode_name(frame->alpha_mode); > > + if (!alpha_mode_str || frame->alpha_mode == AVALPHA_MODE_UNSPECIFIED) > > + av_log(ctx, AV_LOG_INFO, "alpha_mode:unknown\n"); > > Looking at other patches you used `unspecified`, I don't know the > distinction, but should be consistent about one name. Fixed. Maybe we should settle on a clear naming convention for these fields in general? The enums are all named _UNSPECIFIED, but av_color_*_name() instead returns "unknown" for them, with the sole current exception of av_chroma_location_name(). Maybe we should update all of these strings to match the formal enum name. > > > + else > > + av_log(ctx, AV_LOG_INFO, "alpha_mode:%s\n", alpha_mode_str); > > + } > > + > > return ff_filter_frame(inlink->dst->outputs[0], frame); > > } > > > > -- > > 2.50.1 > > > > _______________________________________________ > > ffmpeg-devel mailing list > > ffmpeg-devel@ffmpeg.org > > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > > > To unsubscribe, visit link above, or email > > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".