From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 82B6E4BB85 for ; Wed, 23 Jul 2025 13:57:39 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 0840268D92C; Wed, 23 Jul 2025 16:56:45 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 4A31668D749 for ; Wed, 23 Jul 2025 16:56:33 +0300 (EEST) Received: from haasn.dev (unknown [10.30.1.1]) by haasn.dev (Postfix) with UTF8SMTP id D38DA483D2; Wed, 23 Jul 2025 15:56:28 +0200 (CEST) From: Niklas Haas To: ffmpeg-devel@ffmpeg.org Date: Wed, 23 Jul 2025 15:47:14 +0200 Message-ID: <20250723135626.1390296-12-ffmpeg@haasn.xyz> X-Mailer: git-send-email 2.50.1 In-Reply-To: <20250723135626.1390296-1-ffmpeg@haasn.xyz> References: <20250723135626.1390296-1-ffmpeg@haasn.xyz> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v2 11/18] avfilter/vf_scale: don't ignore incoming chroma location X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Niklas Haas Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: Niklas Haas This filter was, for some reason, always ignoring the incoming chroma location in favor of the user-specified value, even when that value was set to the default (unspecified). This has been the status quo for quite some time, although commit 04ce01df0bb made the situation worse by changing it from only happening when scaling is needed, to always happening even in the no-op case. --- libavfilter/vf_scale.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index aec765b441..54cd0b12b6 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_scale.c @@ -824,7 +824,8 @@ scale: in->color_trc = scale->in_transfer; if (scale->in_range != AVCOL_RANGE_UNSPECIFIED) in->color_range = scale->in_range; - in->chroma_location = scale->in_chroma_loc; + if (scale->in_chroma_loc != AVCHROMA_LOC_UNSPECIFIED) + in->chroma_location = scale->in_chroma_loc; flags_orig = in->flags; if (scale->interlaced > 0) -- 2.50.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".