From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id BDD304BA37 for ; Tue, 22 Jul 2025 16:24:59 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id F0A3568CDE2; Tue, 22 Jul 2025 19:24:52 +0300 (EEST) Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id BA11568CA81 for ; Tue, 22 Jul 2025 19:24:44 +0300 (EEST) Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-236377f00a1so47859355ad.3 for ; Tue, 22 Jul 2025 09:24:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753201481; x=1753806281; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=XR//K4FiW0pk3iT5JN1pX3+0bbgDlv1paprmDUXkLjY=; b=Y1TixO2aWpr60ULh6ud0grFVFukRIhLpHAHOE4ldyH9HeU6buGGAwI6e30jtWfw5YR 3WM3TbUKms+enn1enV1oumLOcRbBEQu5o+12Jia+In6ukBVr79uJwwCVv3y2KwAw5agZ tsYFbPfhjgcvBtR1/0zj+0OB8JKPC6n4SOiASp7KYU1pqLcu8kDjKO6WJcg83AC9xVxi k07tswReVTAM7DAITQi4mHLGyi17jomNDX0qimUPVDGqpDc/czTmJphPpDFw8SMLEvBI XPHbq1VAHgPVPD3US07ADRE8mvfEv36d1OovIRQapVpFC6Z2o3nm8QFnJ2jtnCPoQy60 L32w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753201481; x=1753806281; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XR//K4FiW0pk3iT5JN1pX3+0bbgDlv1paprmDUXkLjY=; b=hTrql5JaSeu+oraKyoOpFLcW2feudE2vtAhvswQJJ1lSuiV8MTYFCIRdU5DZqmuLFX RFZGk7C5EqCRiPTf2+ffqTbZwrx1GRyMZRaZFehKukX6a4arnkxFntpx8/qYoLxL8uyp 60XabmoznmrEwDKMUUq3ePMBXtfDIr9na4RMxLT+lohFldgxEn9TDxpmCrBrGpEOKU5Y fVl3D5NU+ayQ5rRtGLqKbstPdFTmUjJBub7xS52ltC1R7ulFet5C3NSL2A3Ldo3PsU4R KPUv8COkm9faiWszW+6uYKxu53IbBvcwyMX6Nhwi0/hLKDEnJn/NY6qM1ZWKr1q8vCsy g+1Q== X-Gm-Message-State: AOJu0YwUJzgera82XAZoie012YbVutKkl8z4iOmfAQn4mw8b15S6ADqU 4YFea+gWwWnTI7pXuntX+wQLQw4Kw4E48wemxGh/czvSSi0s2Ubmn4hQiaPqrg== X-Gm-Gg: ASbGncvFtPeX/IXadurdgXa6hLabqSNwJcnwEbI4GhF7NvMzm6pJ1j9ZUWWGdt9iLzk vzCfs/BcXBEEIQmv5FyIKkDKQtB7rvwKxVNZyBYByMZpATwMEdVk4hDWdGW24P2agSF56cDkfCM SK4LwU1cq6WaXvnIjRtUuAA9xgrr3pOdOL4YWzG2cU56uL/3Cqh3m7TsfewCkHylYu+3Na67p+7 Jfx/6U7ryJx/51WjQgM47Su2iSE3ItsI/QZvXqjaJn9je/crv4iRblW+uNv5Bd+rO9dybX4D/MO mCeEbng07aTQbz6+pEjWnqv16xo6u9IIZjXaEB8RpYkUXjOP7HQnPJ4NuMe9/H1f6Z2u5jjlo6v WJn3tR0ykV70b7akrqTY= X-Google-Smtp-Source: AGHT+IHf5cLjSv+Ih1VSAhMWjQM/hK0mOAinDtuoY9zn3P38IBMci6fl+7kG4l1Cukm2kKeG4aVvZA== X-Received: by 2002:a17:903:3d0b:b0:234:11f9:a72b with SMTP id d9443c01a7336-23e24f94aeemr367374775ad.50.1753201481186; Tue, 22 Jul 2025 09:24:41 -0700 (PDT) Received: from Gryph ([2800:2121:b000:82e:7141:dbdc:19c3:f04f]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23e3b708244sm79181845ad.227.2025.07.22.09.24.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 22 Jul 2025 09:24:40 -0700 (PDT) From: James Almer To: ffmpeg-devel@ffmpeg.org Date: Tue, 22 Jul 2025 13:24:32 -0300 Message-ID: <20250722162432.3328-1-jamrial@gmail.com> X-Mailer: git-send-email 2.50.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avcodec/opus/silk: don't assume stereo when calling silk_decode_frame() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Fixes use-of-uninitialized-value under MSAN. Signed-off-by: James Almer --- libavcodec/opus/silk.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavcodec/opus/silk.c b/libavcodec/opus/silk.c index 97bb95037c..ffa2ec996b 100644 --- a/libavcodec/opus/silk.c +++ b/libavcodec/opus/silk.c @@ -844,8 +844,10 @@ int ff_silk_decode_superframe(SilkContext *s, OpusRangeCoder *rc, } for (i = 0; i < nb_frames; i++) { - for (j = 0; j < coded_channels && !s->midonly; j++) - silk_decode_frame(s, rc, i, j, coded_channels, active[j][i], active[1][i], 0); + for (j = 0; j < coded_channels && !s->midonly; j++) { + int active1 = coded_channels > 1 ? active[1][i] : 0; + silk_decode_frame(s, rc, i, j, coded_channels, active[j][i], active1, 0); + } /* reset the side channel if it is not coded */ if (s->midonly && s->frame[1].coded) -- 2.50.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".