From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5EE3944B0D for ; Mon, 21 Jul 2025 11:31:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id EE69F68C065; Mon, 21 Jul 2025 14:30:56 +0300 (EEST) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 0003C68C065 for ; Mon, 21 Jul 2025 14:30:47 +0300 (EEST) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-7425bd5a83aso3535271b3a.0 for ; Mon, 21 Jul 2025 04:30:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1753097446; x=1753702246; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bsHIDwb99Gr4bYOD+3Ymcg2ncGSlqIkV3oYH6yw9mBE=; b=VmMqPsNP82drZphrCZ1qouG2Zd4m1nhPoKPM3Yvp4IRBgEy/MqXwIe8Mx0Zg8BAxaK x7C5IFTJoaczWKEO3YfRjCbWcjGqUEi6Tbh2iBY6X4kNELHi7HCbcAbTkGhpNcWYKOFV xMxs1z7M5wcyTI6rhCci2kw+E3jMTpt+rtYjudn/au7gO9nejVPAZgSeu/D+LHbSodxO plXSY8967uIOa5ZvBm56H8aurZUJedrAFqDqMrOWGQ8i2oFV8GeqVF5t7IKHVJwnvY2E AiA1IJ0q/Rwe2O+nk2lJX+A7eD0fwN/pPoMmTq/ubJiBwNchIpCt75K3CDk41qbDaOr4 Z5dw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1753097446; x=1753702246; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bsHIDwb99Gr4bYOD+3Ymcg2ncGSlqIkV3oYH6yw9mBE=; b=kwMgLAzYGrcuWG4M4dbtZVCq8n9uptp5DQxgwQnenVgMrIYLhGAsHjczNczE1Zw217 W2WKMHyZgnTBShO5CQjDG8bK13mus7y3VCSz2z9cGHsu4WIi+EpZsYs7MGU0clenn39H 6bfTSEaTgHETjopSRM5pn+Zxbb+DlWiPPIr86TlarEf0lBtjNeHUZeia+l1AX01q/082 IUMOoJWkTHN6UWzj3jYxlpWDLwBXI63iBQ2ClqrJABLHhPG//V4pfdJwh9pLpQTU+VIk M0N+/5ccsoE+/RsaEUC2dJRcxcWY+iRWiIgT3MmfD/7vYhTnblPDKz3Ev4vymqOg7mG5 1PBQ== X-Gm-Message-State: AOJu0YxodypfeHy/tSlbs3qenyJ0jOSGBr6iqKRO0rWGqHSAIdMxiCcp mRuObq4U5CbbaPG7tlcE68/CuZzP5m3fsAKPbfsAwYOsXxjCg+ernnol08JP5qjr X-Gm-Gg: ASbGncs4E4CH6+XuMTfXzAg6BwIS4mnLEtcLD/OPxRlHL0CQfwzq8XPGYOcFomAv9r2 fENm7SIh0N1eafZaRq8yA6wtc+7kV6RvrEa7i+j+yXgOmykr318tLWiAPLVSU+TMi5KyaLw98PO /jvGa/Tr2zK3rYBvzEbaCYS2uam6YGSwvoxJn536stulsqlBhUkBw5NdBcFHjrpNA6SOe+DkdRK 3vgA7vO0M60T+WK6CjYOY3yrh1fKtPWulPfD4dXHcV7BB1rD4keMS/4RXz02waRTyP09cz8hWZ+ OiYN5iiqkcTyWvapjhnTPn3irHAEeIPk4af1hSO1LcVA2bunPvdG05Z7U0EgTe+ZeplaQ31wAKL EkV+zvR44Az/nlS7FmlbuUwZX19/m2qXK X-Google-Smtp-Source: AGHT+IEmmMEnF4APouxAc+DEyMZWt/Qx5Y+Xr2nKQg6oMRBmF2kRe9/mZF25ov9asp4miufCiVWpMw== X-Received: by 2002:a05:6a21:99a1:b0:21a:d1fe:9e82 with SMTP id adf61e73a8af0-238142698b1mr29147793637.30.1753097445992; Mon, 21 Jul 2025 04:30:45 -0700 (PDT) Received: from localhost.localdomain ([5.34.218.160]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-759cbd68350sm5630277b3a.148.2025.07.21.04.30.43 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Mon, 21 Jul 2025 04:30:45 -0700 (PDT) From: Jack Lau X-Google-Original-From: Jack Lau To: ffmpeg-devel@ffmpeg.org Date: Mon, 21 Jul 2025 19:30:15 +0800 Message-ID: <20250721113023.91931-5-jacklau1222@qq.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250721113023.91931-1-jacklau1222@qq.com> References: <20250721113023.91931-1-jacklau1222@qq.com> MIME-Version: 1.0 X-Unsent: 1 Subject: [FFmpeg-devel] [PATCH v4 04/11] WHIP: X509 cert serial number should be positive. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: winlin , Jack Lau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: winlin See RFC5280 4.1.2.2 Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index a6b358d8f9..778595c721 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -328,7 +328,8 @@ static int openssl_gen_certificate(EVP_PKEY *pkey, X509 **cert, char **fingerpri goto enomem_end; } - serial = (int)av_get_random_seed(); + // According to RFC5280 4.1.2.2, The serial number MUST be a positive integer + serial = (int)(av_get_random_seed() & 0x7FFFFFFF); if (ASN1_INTEGER_set(X509_get_serialNumber(*cert), serial) != 1) { av_log(NULL, AV_LOG_ERROR, "TLS: Failed to set serial, %s\n", ERR_error_string(ERR_get_error(), NULL)); goto einval_end; -- 2.49.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".