[FFmpeg-devel] [PATCH] configure: filter link flags separately for MSVC

[FFmpeg-devel] [PATCH] configure: filter link flags separately for MSVC

[Kacper Michajłow]

This avoids adding flags that cl.exe doesn't understand.

Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
---
 configure | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index ed6430ea32..8a9a9c3c17 100755
--- a/configure
+++ b/configure
@@ -4924,7 +4924,7 @@ msvc_common_flags(){
             -lstdc++)             ;;
             -l*)                  echo ${flag#-l}.lib ;;
             -LARGEADDRESSAWARE)   echo $flag ;;
-            -L*)                  echo -libpath:${flag#-L} ;;
+            -L*) [ "$_flags_type" = "link" ] && echo -libpath:${flag#-L} ;;
             -Wl,*)                ;;
             *)                    echo $flag ;;
         esac
@@ -4946,6 +4946,12 @@ msvc_flags(){
     done
 }
 
+msvc_flags_link(){
+    _flags_type=link
+    msvc_flags "$@"
+    unset flags_type
+}
+
 icl_flags(){
     msvc_common_flags "$@"
     for flag; do
@@ -5172,12 +5178,13 @@ probe_cc(){
         _cflags_noopt="-O1"
         if $_cc -nologo- 2>&1 | grep -q Linker; then
             _ld_o='-out:$@'
+            _flags_filter=msvc_flags_link
         else
             _ld_o='-Fe$@'
+            _flags_filter=msvc_flags
         fi
         _cc_o='-Fo$@'
         _cc_e='-P -Fi$@'
-        _flags_filter=msvc_flags
         _ld_lib='lib%.a'
         _ld_path='-libpath:'
         _flags='-nologo'
-- 
2.50.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] configure: filter link flags separately for MSVC

[Kacper Michajlow]

On Sun, 20 Jul 2025 at 19:23, Kacper Michajłow <kasper93@gmail.com> wrote:

> This avoids adding flags that cl.exe doesn't understand.
>
> Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
> ---
>  configure | 11 +++++++++--
>  1 file changed, 9 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index ed6430ea32..8a9a9c3c17 100755
> --- a/configure
> +++ b/configure
> @@ -4924,7 +4924,7 @@ msvc_common_flags(){
>              -lstdc++)             ;;
>              -l*)                  echo ${flag#-l}.lib ;;
>              -LARGEADDRESSAWARE)   echo $flag ;;
> -            -L*)                  echo -libpath:${flag#-L} ;;
> +            -L*) [ "$_flags_type" = "link" ] && echo -libpath:${flag#-L}
> ;;
>              -Wl,*)                ;;
>              *)                    echo $flag ;;
>          esac
> @@ -4946,6 +4946,12 @@ msvc_flags(){
>      done
>  }
>
> +msvc_flags_link(){
> +    _flags_type=link
> +    msvc_flags "$@"
> +    unset flags_type
>

typo, fixed locally.


> +}
> +
>  icl_flags(){
>      msvc_common_flags "$@"
>      for flag; do
> @@ -5172,12 +5178,13 @@ probe_cc(){
>          _cflags_noopt="-O1"
>          if $_cc -nologo- 2>&1 | grep -q Linker; then
>              _ld_o='-out:$@'
> +            _flags_filter=msvc_flags_link
>          else
>              _ld_o='-Fe$@'
> +            _flags_filter=msvc_flags
>          fi
>          _cc_o='-Fo$@'
>          _cc_e='-P -Fi$@'
> -        _flags_filter=msvc_flags
>          _ld_lib='lib%.a'
>          _ld_path='-libpath:'
>          _flags='-nologo'
> --
> 2.50.1
>
>
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".