Re: [FFmpeg-devel] [PATCH] avcodec/motion_est: don't add offsets to NULL pointers

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1155 bytes --]

On Tue, Jul 15, 2025 at 10:33:10AM -0300, James Almer wrote:
> Fixes: libavcodec/motion_est.c:94:31: runtime error: applying zero offset to null pointer
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavcodec/motion_est.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/libavcodec/motion_est.c b/libavcodec/motion_est.c
> index 93be712cc0..3273451f9a 100644
> --- a/libavcodec/motion_est.c
> +++ b/libavcodec/motion_est.c
> @@ -91,12 +91,12 @@ static inline void init_ref(MotionEstContext *c, uint8_t *const src[3],
>      };
>      int i;
>      for(i=0; i<3; i++){
> -        c->src[0][i]= src [i] + offset[i];
> -        c->ref[0][i]= ref [i] + offset[i];
> +        c->src[0][i]= src[i] ? FF_PTR_ADD(src[i], offset[i]) : NULL;
> +        c->ref[0][i]= ref[i] ? FF_PTR_ADD(ref[i], offset[i]) : NULL;

why does this need FF_PTR_ADD() when the pointer is not NULL ?

patch is ok except that

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Give a rich man 100$ and he will turn it into 1000$.
Give a poor man 1000$ and he will spend it.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".