[FFmpeg-devel] [PATCH v2 1/5] configure: allow multiple sanitizers in --toolchain

[FFmpeg-devel] [PATCH v2 1/5] configure: allow multiple sanitizers in --toolchain

[Kacper Michajłow]

For example this allows --toolchain=clang-asan-usan.

Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
---
 configure | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/configure b/configure
index 10dafae8e2..17a83dd873 100755
--- a/configure
+++ b/configure
@@ -4638,14 +4638,23 @@ add_sanitizer_flags(){
     esac
 }
 
+add_sanitizers(){
+    IFS=-
+    set -- $*
+    unset IFS
+    for sanitizer; do
+        add_sanitizer_flags "$sanitizer"
+    done
+}
+
 case "$toolchain" in
     clang-*)
-        add_sanitizer_flags "${toolchain#clang-}"
+        add_sanitizers "${toolchain#clang-}"
         cc_default="clang"
         cxx_default="clang++"
     ;;
     gcc-*)
-        add_sanitizer_flags "${toolchain#gcc-}"
+        add_sanitizers "${toolchain#gcc-}"
         cc_default="gcc"
         cxx_default="g++"
         # In case of tsan with gcc, PIC has to be enabled
-- 
2.50.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2 2/5] configure: add -fno-omit-frame-pointer when sanitizers are used

[Kacper Michajłow]

All sanitizers give better reports with frame pointers. And skip adding
-fomit-frame-pointer.

Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
---
 configure | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/configure b/configure
index 17a83dd873..11b2a93038 100755
--- a/configure
+++ b/configure
@@ -4645,6 +4645,7 @@ add_sanitizers(){
     for sanitizer; do
         add_sanitizer_flags "$sanitizer"
     done
+    add_cflags -fno-omit-frame-pointer
 }
 
 case "$toolchain" in
@@ -6208,7 +6209,7 @@ set_default libdir
 set_default $PATHS_LIST
 set_default nm
 
-disabled optimizations || enabled ossfuzz || check_cflags -fomit-frame-pointer
+disabled optimizations || enabled ossfuzz || echo "$CFLAGS" | grep -q -- '-fsanitize=' || check_cflags -fomit-frame-pointer
 
 enable_weak_pic() {
     disabled pic && return
-- 
2.50.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 2/5] configure: add -fno-omit-frame-pointer when sanitizers are used

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 508 bytes --]

On Thu, Jul 17, 2025 at 04:04:39AM +0200, Kacper Michajłow wrote:
> All sanitizers give better reports with frame pointers. And skip adding
> -fomit-frame-pointer.
> 
> Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
> ---
>  configure | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

should be ok

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Everything should be made as simple as possible, but not simpler.
-- Albert Einstein

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2 3/5] configure: allow -ubsan in toolchain

[Kacper Michajłow]

It's is commonly called UBSAN after all.

Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
---
 configure | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure b/configure
index 11b2a93038..bff0fe285b 100755
--- a/configure
+++ b/configure
@@ -4628,7 +4628,7 @@ add_sanitizer_flags(){
             add_cflags  -fsanitize=thread
             add_ldflags -fsanitize=thread
         ;;
-        usan)
+        usan|ubsan)
             add_cflags  -fsanitize=undefined
             add_ldflags -fsanitize=undefined
         ;;
-- 
2.50.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 3/5] configure: allow -ubsan in toolchain

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 430 bytes --]

On Thu, Jul 17, 2025 at 04:04:40AM +0200, Kacper Michajłow wrote:
> It's is commonly called UBSAN after all.
> 
> Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
> ---
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

LGTM

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Those who are best at talking, realize last or never when they are wrong.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2 4/5] configure: add -fuzz support to --toolchain

[Kacper Michajłow]

libFuzzer is linked only for fuzzing targets.

Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
---
 configure | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/configure b/configure
index bff0fe285b..4773a507d3 100755
--- a/configure
+++ b/configure
@@ -4616,6 +4616,11 @@ add_sanitizer_flags(){
             add_cflags  -fsanitize=address
             add_ldflags -fsanitize=address
         ;;
+        fuzz)
+            add_cflags  -fsanitize=fuzzer-no-link
+            add_ldflags -fsanitize=fuzzer-no-link
+            : "${libfuzzer_path:=-fsanitize=fuzzer}"
+        ;;
         lsan)
             add_cflags  -fsanitize=leak
             add_ldflags -fsanitize=leak
-- 
2.50.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 4/5] configure: add -fuzz support to --toolchain

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 560 bytes --]

On Thu, Jul 17, 2025 at 04:04:41AM +0200, Kacper Michajłow wrote:
> libFuzzer is linked only for fuzzing targets.
> 
> Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
> ---
>  configure | 5 +++++
>  1 file changed, 5 insertions(+)

tested and seems working

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The real ebay dictionary, page 2
"100% positive feedback" - "All either got their money back or didnt complain"
"Best seller ever, very honest" - "Seller refunded buyer after failed scam"

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v2 5/5] configure: remove ossfuzz sanitizer flags

[Kacper Michajłow]

In OSS-Fuzz build environment flags are handled by CFLAGS and LDFLAGS.
In local build use --toolchain=clang-fuzz-asan-ubsan or similar
combination depending on requested sanitizers.

Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
---
 configure | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/configure b/configure
index 4773a507d3..c0ba3bea87 100755
--- a/configure
+++ b/configure
@@ -4605,11 +4605,6 @@ set >> $logfile
 
 test -n "$valgrind" && toolchain="valgrind-memcheck"
 
-enabled ossfuzz && ! echo $CFLAGS | grep -q -- "-fsanitize="  && ! echo $CFLAGS | grep -q -- "-fcoverage-mapping" &&{
-    add_cflags  -fsanitize=address,undefined -fsanitize-coverage=trace-pc-guard,trace-cmp -fno-omit-frame-pointer
-    add_ldflags -fsanitize=address,undefined -fsanitize-coverage=trace-pc-guard,trace-cmp
-}
-
 add_sanitizer_flags(){
     case "$1" in
         asan)
-- 
2.50.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 5/5] configure: remove ossfuzz sanitizer flags

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 757 bytes --]

On Thu, Jul 17, 2025 at 04:04:42AM +0200, Kacper Michajłow wrote:
> In OSS-Fuzz build environment flags are handled by CFLAGS and LDFLAGS.
> In local build use --toolchain=clang-fuzz-asan-ubsan or similar
> combination depending on requested sanitizers.
> 
> Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
> ---
>  configure | 5 -----
>  1 file changed, 5 deletions(-)

should be ok

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Old school: Use the lowest level language in which you can solve the problem
            conveniently.
New school: Use the highest level language in which the latest supercomputer
            can solve the problem without the user falling asleep waiting.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 1/5] configure: allow multiple sanitizers in --toolchain

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 511 bytes --]

On Thu, Jul 17, 2025 at 04:04:38AM +0200, Kacper Michajłow wrote:
> For example this allows --toolchain=clang-asan-usan.
> 
> Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
> ---
>  configure | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)

does this need some documentation to be updated ?

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 1/5] configure: allow multiple sanitizers in --toolchain

[Kacper Michajlow]

On Fri, 18 Jul 2025 at 18:28, Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Thu, Jul 17, 2025 at 04:04:38AM +0200, Kacper Michajłow wrote:
> > For example this allows --toolchain=clang-asan-usan.
> >
> > Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
> > ---
> >  configure | 13 +++++++++++--
> >  1 file changed, 11 insertions(+), 2 deletions(-)
>
> does this need some documentation to be updated ?


I can update configure help, but not sure what would be a good format.
Currently it just lists all possible selections, but this wouldn't work now.

Would something like this work?

--- a/configure
+++ b/configure
@@ -381,10 +381,10 @@ Toolchain options:
   --target-samples=DIR     path to samples directory on target
   --tempprefix=PATH        force fixed dir/prefix instead of mktemp for
checks
   --toolchain=NAME         set tool defaults according to NAME
-                           (gcc-asan, clang-asan, gcc-msan, clang-msan,
-                           gcc-tsan, clang-tsan, gcc-usan, clang-usan,
-                           valgrind-massif, valgrind-memcheck,
-                           msvc, icl, gcov, llvm-cov, hardened)
+                          (<tool>[-sanitizer[-...]], e.g. clang-asan-usan
+                          tools: gcc, clang, msvc, icl, gcov, llvm-cov,
+                                 valgrind-memcheck, valgrind-massif,
hardened
+                          sanitizers: asan, msan, tsan, usan)
   --nm=NM                  use nm tool NM [$nm_default]
   --ar=AR                  use archive tool AR [$ar_default]
   --as=AS                  use assembler AS [$as_default]

- Kacper
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 1/5] configure: allow multiple sanitizers in --toolchain

[Michael Niedermayer]

[-- Attachment #1.1: Type: text/plain, Size: 1822 bytes --]

On Fri, Jul 18, 2025 at 06:49:24PM +0200, Kacper Michajlow wrote:
> On Fri, 18 Jul 2025 at 18:28, Michael Niedermayer <michael@niedermayer.cc>
> wrote:
> 
> > On Thu, Jul 17, 2025 at 04:04:38AM +0200, Kacper Michajłow wrote:
> > > For example this allows --toolchain=clang-asan-usan.
> > >
> > > Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
> > > ---
> > >  configure | 13 +++++++++++--
> > >  1 file changed, 11 insertions(+), 2 deletions(-)
> >
> > does this need some documentation to be updated ?
> 
> 
> I can update configure help, but not sure what would be a good format.
> Currently it just lists all possible selections, but this wouldn't work now.
> 
> Would something like this work?
> 
> --- a/configure
> +++ b/configure
> @@ -381,10 +381,10 @@ Toolchain options:
>    --target-samples=DIR     path to samples directory on target
>    --tempprefix=PATH        force fixed dir/prefix instead of mktemp for
> checks
>    --toolchain=NAME         set tool defaults according to NAME
> -                           (gcc-asan, clang-asan, gcc-msan, clang-msan,
> -                           gcc-tsan, clang-tsan, gcc-usan, clang-usan,
> -                           valgrind-massif, valgrind-memcheck,
> -                           msvc, icl, gcov, llvm-cov, hardened)
> +                          (<tool>[-sanitizer[-...]], e.g. clang-asan-usan
> +                          tools: gcc, clang, msvc, icl, gcov, llvm-cov,
> +                                 valgrind-memcheck, valgrind-massif,hardened
> +                          sanitizers: asan, msan, tsan, usan)

LGTM

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

During times of universal deceit, telling the truth becomes a
revolutionary act. -- George Orwell

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v2 1/5] configure: allow multiple sanitizers in --toolchain

[Kacper Michajlow]

On Fri, 18 Jul 2025 at 18:53, Michael Niedermayer <michael@niedermayer.cc>
wrote:

> On Fri, Jul 18, 2025 at 06:49:24PM +0200, Kacper Michajlow wrote:
> > On Fri, 18 Jul 2025 at 18:28, Michael Niedermayer <
> michael@niedermayer.cc>
> > wrote:
> >
> > > On Thu, Jul 17, 2025 at 04:04:38AM +0200, Kacper Michajłow wrote:
> > > > For example this allows --toolchain=clang-asan-usan.
> > > >
> > > > Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
> > > > ---
> > > >  configure | 13 +++++++++++--
> > > >  1 file changed, 11 insertions(+), 2 deletions(-)
> > >
> > > does this need some documentation to be updated ?
> >
> >
> > I can update configure help, but not sure what would be a good format.
> > Currently it just lists all possible selections, but this wouldn't work
> now.
> >
> > Would something like this work?
> >
> > --- a/configure
> > +++ b/configure
> > @@ -381,10 +381,10 @@ Toolchain options:
> >    --target-samples=DIR     path to samples directory on target
> >    --tempprefix=PATH        force fixed dir/prefix instead of mktemp for
> > checks
> >    --toolchain=NAME         set tool defaults according to NAME
> > -                           (gcc-asan, clang-asan, gcc-msan, clang-msan,
> > -                           gcc-tsan, clang-tsan, gcc-usan, clang-usan,
> > -                           valgrind-massif, valgrind-memcheck,
> > -                           msvc, icl, gcov, llvm-cov, hardened)
> > +                          (<tool>[-sanitizer[-...]], e.g.
> clang-asan-usan
> > +                          tools: gcc, clang, msvc, icl, gcov, llvm-cov,
> > +                                 valgrind-memcheck,
> valgrind-massif,hardened
> > +                          sanitizers: asan, msan, tsan, usan)
>
> LGTM
>
> thx


Applied patchset, thanks.

- Kacper
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".