Re: [FFmpeg-devel] [PATCH 3/4] avcodec/h264dec: implement export of video coding info for H.264

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 3/4] avcodec/h264dec: implement export of video coding info for H.264
Date: Fri, 18 Jul 2025 16:17:34 +0200
Message-ID: <20250718141734.GB29660@pb2> (raw)
In-Reply-To: <20250718103055.1172733-3-timothee.informatique@regaud-chapuy.fr>

[-- Attachment #1.1: Type: text/plain, Size: 2863 bytes --]

On Fri, Jul 18, 2025 at 12:30:54PM +0200, Timothée Regaud wrote:
> From: Timothee Regaud <timothee.informatique@regaud-chapuy.fr>
> 
> Hooks into the H.264 decoder to populate the new generic video coding info structures. It handles allocation of the side data buffer, collection of modes/MVs/refs for all macroblock types, and attach the final side data buffer to the output frame.
> 
> This should serve as a template for adding support for other codecs down the line.
> 
> Signed-off-by: Timothee Regaud <timothee.informatique@regaud-chapuy.fr>
> ---
>  Changelog                     |   1 +
>  libavcodec/h264_mb.c          | 150 ++++++++++++++++++++++++++++++++++
>  libavcodec/h264_mb_template.c |   3 +
>  libavcodec/h264_picture.c     |   3 +
>  libavcodec/h264_slice.c       |  19 +++++
>  libavcodec/h264dec.c          |  17 ++++
>  libavcodec/h264dec.h          |  12 +++
>  7 files changed, 205 insertions(+)
> 
[...]
> @@ -102,6 +103,14 @@
>  // does this mb use listX, note does not work if subMBs
>  #define USES_LIST(a, list) ((a) & ((MB_TYPE_P0L0 | MB_TYPE_P1L0) << (2 * (list))))
>  
> +/* Constants for AVVideoCodingInfo buffer allocation for H.264.
> + * Max sub-data per MB is for inter prediction with 16 partitions. */
> +static const size_t H264_MAX_MV_SIZE_PER_LIST = 16 * sizeof(int16_t[2]);
> +static const size_t H264_MAX_REF_SIZE_PER_LIST = 16 * sizeof(int8_t);
> +static const size_t H264_INTER_SUB_DATA_SIZE = 2 * (H264_MAX_MV_SIZE_PER_LIST + H264_MAX_REF_SIZE_PER_LIST);
> +static const size_t H264_INTRA_SUB_DATA_SIZE = 16 * sizeof(int8_t);
> +static const size_t H264_MAX_SUB_DATA_PER_MB = FFMAX(H264_INTER_SUB_DATA_SIZE, H264_INTRA_SUB_DATA_SIZE);

CC	libavfilter/vf_codecview.o
In file included from src/libavfilter/vf_codecview.c:45:0:
src/libavcodec/h264dec.h:110:48: error: initializer element is not constant
 static const size_t H264_INTER_SUB_DATA_SIZE = 2 * (H264_MAX_MV_SIZE_PER_LIST + H264_MAX_REF_SIZE_PER_LIST);
                                                ^
In file included from src/libavutil/error.h:30:0,
                 from src/libavutil/common.h:43,
                 from src/libavutil/avutil.h:300,
                 from src/libavutil/opt.h:31,
                 from src/libavfilter/vf_codecview.c:34:
src/libavutil/macros.h:47:20: error: initializer element is not constant
 #define FFMAX(a,b) ((a) > (b) ? (a) : (b))
                    ^
src/libavcodec/h264dec.h:112:48: note: in expansion of macro ‘FFMAX’
 static const size_t H264_MAX_SUB_DATA_PER_MB = FFMAX(H264_INTER_SUB_DATA_SIZE, H264_INTRA_SUB_DATA_SIZE);

arm-linux-gnueabi-gcc-7 (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) 7.5.0

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".