From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 2FAF34AB36 for ; Fri, 18 Jul 2025 13:08:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 9F1B868CF23; Fri, 18 Jul 2025 16:08:46 +0300 (EEST) Received: from relay8-d.mail.gandi.net (relay8-d.mail.gandi.net [217.70.183.201]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id AB6A468CD50 for ; Fri, 18 Jul 2025 16:08:40 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id BC1144441E for ; Fri, 18 Jul 2025 13:08:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1752844119; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=m811ko+FJFoZFAZwOiFfog9jIPO2Tn7Kwbt3cST8d1A=; b=GOYSafI9nHCWO93dx7Vl48INnFSHcNGryGsmfKlgiJJ3YpN3MP8VoilZdYCLvV4hBZes8+ TL3P8clk1lvGqzwyRO11dBne5eWU4hC2Qt/ff/K4fTbxWn76hz0zV2BCD52VBnQr4DpDzl OPXOuvLilcM8LZZMkWuGRERPWKLk4M7itf15+/LaF0dl306kQv7jas/3Ab1fUcsVe8vwjO 4E7cNPIxYbT0xWm1uO8ddNx1lWcPl94f5tfqzkiA+DhA2eyQMFR+NuVO/vCRgr/6lQ2KXJ Q2S7Nt0CmZefsL+aTchNznygGl7rbZp74sDoFOjZntdMbJ3iBsZAYtXpjq7Pnw== Date: Fri, 18 Jul 2025 15:08:38 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250718130838.GA29660@pb2> References: <20250527102811.369474-1-marcos@orca.pet> <1210481741.184664378.1748342436436.JavaMail.zimbra@orca.pet> <204e8be99e97c2a9d56c5fbd0f51c4540452a436.camel@haerdin.se> MIME-Version: 1.0 In-Reply-To: <204e8be99e97c2a9d56c5fbd0f51c4540452a436.camel@haerdin.se> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdeifeehgecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtudenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepfeekkeefheetvdegffeigfefteeggeetleeuueeuveeufeelleeghffgteetfeegnecuffhomhgrihhnpeiffedrohhrghenucfkphepgedurdeiiedrieehrddujeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieehrddujeeipdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] avformat/webvttdec: improve WebVTT parsing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2776384131915333711==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2776384131915333711== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="QAeEkvQG15cErc/M" Content-Disposition: inline --QAeEkvQG15cErc/M Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi Tomas On Fri, Jun 06, 2025 at 09:43:58PM +0200, Tomas H=E4rdin wrote: > tis 2025-05-27 klockan 10:40 +0000 skrev Marcos Del Sol via ffmpeg- > devel: > > A note on this change: I found some .vtt files while using yt-dlp > > that follow > > a draft version of the WebVTT standard (probably > > https://www.w3.org/2013/07/webvtt.html) that use "Region:" for > > regions instead > > of "REGION", and that was causing the conversion to .srt to fail > > completely. >=20 > Sounds like the demuxer correctly rejected some broken files >=20 > > + res =3D webvtt_parse_cue(webvtt, &cue, pos); > > + if (res < 0) { > > + if (res !=3D AVERROR_INVALIDDATA) > > + goto end; > > + av_log(s, AV_LOG_DEBUG, "Ignoring non-cue block at > > 0x%"PRIx64"\n", pos); > > } >=20 > This kind of change will cause broken files to proliferate, which is > bad for the WebVTT ecosystem, bringing it closer to the mess that is > the SubRip ecosystem at the risk of not getting the joke across but you are mixing up germanic, french and latin. Should we really be proliferating that mess ? ;) thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Let us carefully observe those good qualities wherein our enemies excel us and endeavor to excel them, by avoiding what is faulty, and imitating what is excellent in them. -- Plutarch --QAeEkvQG15cErc/M Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaHpHVgAKCRBhHseHBAsP q11sAJ0WDB4MBc6T8bvl6qC/Gi4br0zWtQCfU78LYr3CCbJExj/eI1m7U5CbZNU= =8dmD -----END PGP SIGNATURE----- --QAeEkvQG15cErc/M-- --===============2776384131915333711== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2776384131915333711==--