From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 95B9E4A9B7 for ; Fri, 18 Jul 2025 12:37:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 89B2168CD87; Fri, 18 Jul 2025 15:36:59 +0300 (EEST) Received: from relay16.mail.gandi.net (relay16.mail.gandi.net [217.70.178.236]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id EAD1168CD4E for ; Fri, 18 Jul 2025 15:36:52 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 18CB14497A for ; Fri, 18 Jul 2025 12:36:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1752842212; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PDvQUrNeYpMzIlfg2u5bcwLLaIyf0ZAGUEeP9wK7Y6Y=; b=gJkyXOsO8EZ8Tr9qRCHFFvUmYs3pOJtDXko/g9AKM8+a2roMhx82HeCdHCRct1zy2ItTtV VZySrYy3FLNiBwIYyfrKOTRI392LlPIvShmGJCYTdpYyxt5KhQEUBIO6DcbKC98mOPy2w/ DsIHIaZT1mzzlexjc9TLekBcGwOeiRaFkXtKHJo13AkR2A9BPRYz0FfrLLxyh1m/QgxIYO S2np/G4ETkpW/A5IYWL7vMc67RJiyuAIFmfc4UTk0LBBumSVjEEQFSKe50Ubufrqb9zXqX jt/qr9Gn87CRJduLiUuQToDdTHoNBA34PAjqAM1KHVkGTJ975ue+BR+4pj6Bdw== Date: Fri, 18 Jul 2025 14:36:51 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250718123651.GY29660@pb2> References: <20250711095439.332634-1-nicolas.gaullier@cji.paris> <20250711095439.332634-2-nicolas.gaullier@cji.paris> <20250712105258.GY29660@pb2> <8dc41b4b-6f4d-405e-ba66-77ed851d43d1@cji.paris> MIME-Version: 1.0 In-Reply-To: <8dc41b4b-6f4d-405e-ba66-77ed851d43d1@cji.paris> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdeifeegjecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeihedrudejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeihedrudejiedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh Subject: Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec/aac_ac3_parser: simplify X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============7114645560576626010==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7114645560576626010== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="jH1U18l6/M+q9MJg" Content-Disposition: inline --jH1U18l6/M+q9MJg Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 15, 2025 at 09:38:53AM +0200, Nicolas Gaullier wrote: > On 7/12/25 12:52, Michael Niedermayer wrote: > > On Fri, Jul 11, 2025 at 11:54:29AM +0200, Nicolas Gaullier wrote: > > > Remove unused USAC/ADTS code: ff_adts_header_parse() parse the > > > object_type from a 2 bits field. > > > See also 696ea1c2236842572df88d573e24a39be3f19c98. > > >=20 > > > Use ff_adts_header_parse_buf() wrapper to simplify as GetBitContext is > > > no longer needed (it was introduced for USAC). > > >=20 > > > Partially reverts 64bb91fd3b5a00a8849531c7e8dd207f2a626096. > > >=20 > > > Signed-off-by: Nicolas Gaullier > > > --- > > > libavcodec/aac_ac3_parser.c | 7 +++---- > > > 1 file changed, 3 insertions(+), 4 deletions(-) > > >=20 > > > diff --git a/libavcodec/aac_ac3_parser.c b/libavcodec/aac_ac3_parser.c > > > index e10ce13a3b..b49ce0277c 100644 > > > --- a/libavcodec/aac_ac3_parser.c > > > +++ b/libavcodec/aac_ac3_parser.c > > > @@ -147,15 +147,14 @@ get_next: > > > } else { > > > #if CONFIG_AAC_PARSER > > > AACADTSHeaderInfo hdr; > > > - GetBitContext gb; > > >=20 > > > - init_get_bits8(&gb, buf, buf_size); > > > if (buf_size < AV_AAC_ADTS_HEADER_SIZE || > > > - ff_adts_header_parse(&gb, &hdr) < 0) > > > + ff_adts_header_parse_buf(buf, &hdr) < 0) > > > return i; > > >=20 > > > avctx->profile =3D hdr.object_type - 1; > > > - s1->key_frame =3D (avctx->profile =3D=3D AV_PROFILE_AAC_= USAC) ? get_bits1(&gb) : 1; > > > + /* ADTS does not support USAC */ > > > + s1->key_frame =3D 1; > > > bit_rate =3D hdr.bit_rate; > > Are these 2 changes related ? > > if not they are maybe better in 2 seperate patches >=20 > They are related in that they both are partial revert of the same commit, > and they both apply to the same code section (so order matter). > I split it into two patches as I think it makes it clearer. I think it should be 3 patches not 2 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Dictatorship naturally arises out of democracy, and the most aggravated form of tyranny and slavery out of the most extreme liberty. -- Plato --jH1U18l6/M+q9MJg Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaHo/2QAKCRBhHseHBAsP qz6uAJ9b+ou6nQ0shLlaEuvr8j0iAq9mmgCgliXqRAnZb2dUk3DvCzZ1v72dLqc= =5q2z -----END PGP SIGNATURE----- --jH1U18l6/M+q9MJg-- --===============7114645560576626010== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7114645560576626010==--