[FFmpeg-devel] [PATCH 1/5] avformat/udp: avoid warning about always false comparision

From: "Kacper Michajłow" <kasper93@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: "Kacper Michajłow" <kasper93@gmail.com>
Subject: [FFmpeg-devel] [PATCH 1/5] avformat/udp: avoid warning about always false comparision
Date: Thu, 17 Jul 2025 01:57:02 +0200
Message-ID: <20250716235707.66547-1-kasper93@gmail.com> (raw)

socklen_t underlying type can be signed or unsigned depending on
platform. This is fine, just cast it to size_t before comparision.

Fixes: warning: result of comparison of unsigned expression < 0 is
       always false [-Wtautological-unsigned-zero-compare]

Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
---
 libavformat/udp.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libavformat/udp.c b/libavformat/udp.c
index 0fde3548e7..035db785c2 100644
--- a/libavformat/udp.c
+++ b/libavformat/udp.c
@@ -473,7 +473,7 @@ int ff_udp_set_remote_addr(URLContext *h, const struct sockaddr *dest_addr, sock
     UDPContext *s = h->priv_data;
 
     /* set the destination address */
-    if (dest_addr_len < 0 || dest_addr_len > sizeof(s->dest_addr))
+    if ((size_t)dest_addr_len > sizeof(s->dest_addr))
         return AVERROR(EIO);
     s->dest_addr_len = dest_addr_len;
     memcpy(&s->dest_addr, dest_addr, dest_addr_len);
-- 
2.50.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
