From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D7DAD49321 for ; Wed, 16 Jul 2025 13:21:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 473B068E4FC; Wed, 16 Jul 2025 16:21:27 +0300 (EEST) Received: from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net [217.70.183.199]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 11E6668E4DB for ; Wed, 16 Jul 2025 16:21:20 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 4A1B8439E3 for ; Wed, 16 Jul 2025 13:21:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1752672079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W8u49QptUqnMGERXdEKVVHunzVxsc0h7mYe7oD4UFXo=; b=elnpsxVe3aJw9k+k4MP9wKxjLAPOxaSnO4ugVqm1WWY2eRkXLNwt7CbYWwXjfUNk8h0gLz k2DV0HWWAi6vrcDfPAPb3v12La4KgdTMwIKnVHm/RokamWA0WFbboAhNcf2kqhvXNb3kpx a8oGV7Zo6Lb8cl5AJgdrXI6tkX3A9+gXQJIHfg122uFQGeDVAPkDqQ5vIgy/w4rjevELC1 PF3nvguXXg4iOTzfLl+nLD/l2HNtsGmWOcZ55IRc0QzBnqcViR6+efN2PMAh2zvKlsIHxz H9bIAyR7FCZ/5+fFV09omJQwW7fhjzrYD8cxbjPrvS99tjJfH9uk5AaHTWyw/g== Date: Wed, 16 Jul 2025 15:21:18 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250716132118.GU29660@pb2> References: <20250714222429.2532133-1-michael@niedermayer.cc> <05b0fe3d-ba9d-49a1-873c-145dbb657a63@frankplowman.com> MIME-Version: 1.0 In-Reply-To: <05b0fe3d-ba9d-49a1-873c-145dbb657a63@frankplowman.com> X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdehjeekudcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlfedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeihedrudejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeihedrudejiedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] configure: Update ossfuzz stuff to clang-12+ X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6224468838077096969==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6224468838077096969== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="tnN/YQkyrt8iKBys" Content-Disposition: inline --tnN/YQkyrt8iKBys Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Wed, Jul 16, 2025 at 11:11:13AM +0100, Frank Plowman wrote: >=20 >=20 > On 16/07/2025 18:58, Kacper Michajlow wrote: > > On Tue, 15 Jul 2025 at 00:24, Michael Niedermayer > > wrote: > >> > >> --- > >> configure | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> diff --git a/configure b/configure > >> index fc082d5467e..e568eed55d3 100755 > >> --- a/configure > >> +++ b/configure > >> @@ -4606,8 +4606,8 @@ set >> $logfile > >> test -n "$valgrind" && toolchain=3D"valgrind-memcheck" > >> > >> enabled ossfuzz && ! echo $CFLAGS | grep -q -- "-fsanitize=3D" && ! = echo $CFLAGS | grep -q -- "-fcoverage-mapping" &&{ > >> - add_cflags -fsanitize=3Daddress,undefined -fsanitize-coverage=3D= trace-pc-guard,trace-cmp -fno-omit-frame-pointer > >> - add_ldflags -fsanitize=3Daddress,undefined -fsanitize-coverage=3D= trace-pc-guard,trace-cmp > >> + add_cflags -fsanitize=3Dfuzzer,address,undefined -fsanitize-memo= ry-track-origins -fno-omit-frame-pointer > >> + add_ldflags -fsanitize=3Daddress,undefined > >> } > >=20 > > How about we remove this block of code? Or move it to > > --toolchain=3Dclang-fuzz for local build? In oss-fuzz build environment > > (docker) this flags shouldn't be injected (and are not because of grep > > checks) and instead CFLAGS are used for compile flags and > > --libfuzzer for linking. > >=20 > > - Kacper >=20 > +1 >=20 > I have a patch locally which does something similar. We could add these > flags only to those targets which need to be compiled with libfuzzer, > rather than to all CFLAGS. It saves you having to re-configure if you > want to compile some fftool, then some fuzzer binary or vice-versa. I expect that the code a bug is in needs to be build with the sanitizer and related flags. And that anything that we want fuzzed needs the fuzzer and related flags So that basically means everything needs these flags IIUC in fact even external libs would need them thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who are best at talking, realize last or never when they are wrong. --tnN/YQkyrt8iKBys Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaHenSgAKCRBhHseHBAsP qwtNAJ9qcr2R+MGNo3GJhbMwhvkEKOYuswCbBrfRuW4Lrz0cPqXdKCyjMMh/n/4= =y55L -----END PGP SIGNATURE----- --tnN/YQkyrt8iKBys-- --===============6224468838077096969== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6224468838077096969==--