From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id DB64844AFC for ; Tue, 15 Jul 2025 00:31:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3AF2368F0F1; Tue, 15 Jul 2025 03:31:20 +0300 (EEST) Received: from mail-yb1-f177.google.com (mail-yb1-f177.google.com [209.85.219.177]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 7CF8C68ECB8 for ; Tue, 15 Jul 2025 03:31:14 +0300 (EEST) Received: by mail-yb1-f177.google.com with SMTP id 3f1490d57ef6-e75668006b9so4922602276.3 for ; Mon, 14 Jul 2025 17:31:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752539472; x=1753144272; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=MnkZuw3vGKzj7ffggkUbOObsyLKL/SU1zHs8MHgcTwI=; b=hqxyh9Ulk6fQOCtihZTCay+H4qN8qKp+anXFJmxxBZIW+fqfvT3KSZHH/EZqPHJn+8 TWrYSjrkfnMgnHObXp4X8TtsJR/SPX3PHKnswub7g4e9fwuaWU9+kXWziONoEqZdpors 4OuJQkAXzoD9Vj4Tj0AcVGfY2p42/IIHcNFAOCMkZ6laJ5X5bIEHoIyR6e56wa/zv7O7 LaxtkCfZ81Yv+3dW2kQZ5JVCGbrb77X6f7RTou6x6Je12WfK/hs8Dt72QU8z+RRViaVS RmpeY6K8HM3KbPEtCibZXz4L84dJiHVVu638UeYqQ+lbYq2TaEa5nFNHbwS5uHuJVBQ5 E1IQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752539472; x=1753144272; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MnkZuw3vGKzj7ffggkUbOObsyLKL/SU1zHs8MHgcTwI=; b=f6ZGTv2iGkfZqTv6CfiiUFB5Et4i5d/toJnP1W0Vi6L925zbhfLvNMsoFcEYy173Bg SgdYewjY9L5EKiTN4i8qdAlGZV45/2L6rhxm93YiiwJrKoOpn0AHj4UIc50LpTEmkT08 d1ZgoPEVx6WGRn25vjdrGWtstf6yPo5DRUPoarqKgdCWWMCiYQxYlryWGV3LsQIJqcMI t5LAUVyJJpUPqCoXJsRsiIG3AAYd8e84DpQKIT5f3fbZSg/Wb5iAKhgqQakQ5JwXGk5m 1wpcEtZoMfAZ8NZIphrCvI/8uVG/uYuy7a9Zf07O3TmcIdbCC1br2MyS6FnrDAcEJpLo S7Sw== X-Gm-Message-State: AOJu0YziVhufIZpvy1hHB6HWfCKT2nxqf9rB0+3Yy7ME9tZFj7CuVzcY 6TNrgNdh3sEGFR7Wwo7zojh4SOApvYkt1Ex9oD2E9JSN7fM13yI2aR30NTCe2A== X-Gm-Gg: ASbGnctYwhX57OCIRUSj3WGxP5GsWs/vDJmTMO9VNxHNuvr025pNFvFfJln8FO9baoI IIxdBWqS6IiHCx0b9I1t/c/laTrOaWkcu1wf1fLX/zZDKWQtFNGWCU9V86bc3ZXZZ1M+QGtY/6+ 069sczVoXEQdZm815T+w58OoyAgNitL8tWLKNbf7vptBA4Hk7wvtjng7QIdpVQF6TgMPM+iunPQ qNOoDj0Rvc5XOk6vwrNDJULanJuT19msJUUsNOejKd8Vka+TA6Z+aeQ9TVC/8q8zoqa6YztCHr6 hezoU9udD6vqPyoxTmpNLZf6H/Ql1PrpAO1bc4+RNOIG1si2GoulSdlwQ+agnyzXcwfXQDTfmq3 y/YHzIEJwRnWUusOC8TyciM1IiE1dqlpq9ln+nMixB2qS X-Google-Smtp-Source: AGHT+IElpqb1ooeKTNJ9LrAxKvwL1oEWs2iX0alVP7+0ng+W1vpwn+SX97F6IPgTpIfBVE9MtM7V5g== X-Received: by 2002:a05:6902:5008:b0:e89:8fe8:a978 with SMTP id 3f1490d57ef6-e8b85af4453mr13463130276.30.1752539472415; Mon, 14 Jul 2025 17:31:12 -0700 (PDT) Received: from newman.cs.purdue.edu ([128.10.127.250]) by smtp.gmail.com with ESMTPSA id 3f1490d57ef6-e8b7afcd1d2sm3201361276.45.2025.07.14.17.31.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 17:31:11 -0700 (PDT) From: Jiasheng Jiang To: ffmpeg-devel@ffmpeg.org Date: Tue, 15 Jul 2025 00:31:09 +0000 Message-Id: <20250715003109.7028-1-jiashengjiangcool@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH v3] fftools/cmdutils: Add av_freep() to avoid memory leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jiasheng Jiang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Add av_freep() to free new_elem to avoid memory leak. Fixes: 3ca1e31e63 ("fftools/cmdutils: Atomically add elements to list of pointers, fix crash") Signed-off-by: Jiasheng Jiang --- Changelog: v2 -> v3: 1. Replace with a correct fixes tag. v1 -> v2: 1. Remove the unnecessary return NULL. --- fftools/cmdutils.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index e442935cae..dc093b0bd3 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -1471,9 +1471,12 @@ void *allocate_array_elem(void *ptr, size_t elem_size, int *nb_elems) { void *new_elem; - if (!(new_elem = av_mallocz(elem_size)) || - av_dynarray_add_nofree(ptr, nb_elems, new_elem) < 0) + new_elem = av_mallocz(elem_size); + if (!new_elem) return NULL; + if (av_dynarray_add_nofree(ptr, nb_elems, new_elem) < 0) + av_freep(&new_elem); + return new_elem; } -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".