From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D097B44B59 for ; Mon, 14 Jul 2025 18:47:18 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 32B2F68EDF2; Mon, 14 Jul 2025 21:47:14 +0300 (EEST) Received: from mail-yw1-f174.google.com (mail-yw1-f174.google.com [209.85.128.174]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 1CBD968EDD1 for ; Mon, 14 Jul 2025 21:47:07 +0300 (EEST) Received: by mail-yw1-f174.google.com with SMTP id 00721157ae682-714067ecea3so35924417b3.0 for ; Mon, 14 Jul 2025 11:47:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752518825; x=1753123625; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=y6ADyOGmUKdZb3EhDWcs5XqQKOu1vMNj+9h5bnna6h4=; b=LQ2KrpoFM++CmaMTpQGfnspUBXJHQqch+xW6HjWVvEM3bNU9lpacfqub9DOkVlvNf+ QtqN44tUXhBFDb2s2L1e72xZW6IU0DxwKfYuTLyq4iIwB0ji4LlOjC6WqrbM89ms/5zQ 5i9ZGvxtZ93lPDS/Jo0rfjkGIRXhWItV3COeod2lCQJQ8ofp4PkDmgpaZMvi6U8/Piyf i/8ksPTjrfwtyUl/4LJHW3t2O4xeW7XeurLBb+VkJXoaHBnIk4ucUWTDzcf+JFWn6rX7 c4wA3wBVJJ6UipV8SZVfVcyGWRIv4VpVYwmsaEcx8rPD+ZlnHlp3U1ZNrywE0m0UzXvQ kTIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752518825; x=1753123625; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=y6ADyOGmUKdZb3EhDWcs5XqQKOu1vMNj+9h5bnna6h4=; b=UDMYs/Y/Sp6baYTvFWprr/fbxNZmFngUqhDG1fXMtvaLMTIxtlqtgiTw9DgoTTXjjs hpAusM8/GVjwu1+SWGVYdiZb+miixJsBl8F8k5I/NdlzWdwCZMZurFYgtmI4Fopz6TbL xRBH8RPtOjELJqIAFgc+TMwEwiPo8wgffnmkKVSescKH3n+AfiuhY5oUxz7Pnx+nJvar xkDsf2ZoP1xK44Gkt/35OOvvoRFBA6cD1byKsHC+9v6EpihzGFmLY4g76qagTTupHpNH 8kJ4v735YGgXliBGq1Y7U2VDzJ45p0m3qq9FjWBEM2z6h3BUsvIXGyoiHEvoUrBAA/3Y WIQg== X-Gm-Message-State: AOJu0YzMk0Mf1na786ISP2niJdulb+mW8P2sSK+NB4YqQm3SBij5zz1D 3vnsozIfIuzobIhDslLpzfyoK/KSUCVmYxYLi8rbvnLV4RT4UtdaTdUOWPO16g== X-Gm-Gg: ASbGnctdppE4mhscL+aKr55wyaubA0C1FioUwSjgwTCMvCNLlNOYfFJjoMfFKfBL2J9 cKbPPoeqbml1DWlCFR3ga6cMHhuOBA5FfzrCvUCVM/C6+ShpNFU3D7lNQiTaH0csA4tF54exDI8 sI6fFM1+oWuC3hfDLjHe1/fTpljYFFF0oXhCRDdLuY5oVW2srMnDJdDJ5dgIcq5zul30sXmsqtp cdyxySpM9pkmRD7E/Ccc1sQFO7+Me80rcqpO0GfEDNVXdTX5bzAWTzBD6pzgNuEpIccaomuQt6D WyJVRBsdoNiG5pMkvmFfXkz0wE1dGtF9dZxmcs2qvKcmNFaAJ0etVCylZKZtZyS5XlIZqHyCbHD 4rhvul3S2Ab8xxzD/3IuTN3bNB6dXeGeiykQW6gCxmzop X-Google-Smtp-Source: AGHT+IGlIK+yb3y972pIciztzn2burJQyGn1qDlbwR4NSTmdbFU2akLMaGWVdy+Gpe6XwDF3KLpxlA== X-Received: by 2002:a05:690c:3:b0:707:dba5:2e44 with SMTP id 00721157ae682-717d7a36e49mr219818547b3.30.1752518824992; Mon, 14 Jul 2025 11:47:04 -0700 (PDT) Received: from newman.cs.purdue.edu ([128.10.127.250]) by smtp.gmail.com with ESMTPSA id 00721157ae682-717c61b4b7dsm20738667b3.58.2025.07.14.11.47.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 14 Jul 2025 11:47:04 -0700 (PDT) From: Jiasheng Jiang To: ffmpeg-devel@ffmpeg.org Date: Mon, 14 Jul 2025 18:47:02 +0000 Message-Id: <20250714184702.3271-1-jiashengjiangcool@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] fftools/ffplay: Add check for av_malloc_array() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jiasheng Jiang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Add check for the return value of av_malloc_array() to avoid potential NULL pointer dereference. Fixes: 4acd08be6c ("ffplay: port to lavu/tx") Signed-off-by: Jiasheng Jiang --- fftools/ffplay.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 2a572fc3aa..12c626c851 100644 --- a/fftools/ffplay.c +++ b/fftools/ffplay.c @@ -1156,7 +1156,7 @@ static void video_audio_display(VideoState *s) err = av_tx_init(&s->rdft, &s->rdft_fn, AV_TX_FLOAT_RDFT, 0, 1 << rdft_bits, &rdft_scale, 0); } - if (err < 0 || !s->rdft_data) { + if (err < 0 || !s->real_data || !s->rdft_data) { av_log(NULL, AV_LOG_ERROR, "Failed to allocate buffers for RDFT, switching to waves display\n"); s->show_mode = SHOW_MODE_WAVES; } else { -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".