From: Jiasheng Jiang <jiashengjiangcool@gmail.com>
To: ffmpeg-devel@ffmpeg.org
Cc: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Subject: [FFmpeg-devel] [PATCH] fftools/ffplay: Add check for av_malloc_array()
Date: Mon, 14 Jul 2025 18:47:02 +0000
Message-ID: <20250714184702.3271-1-jiashengjiangcool@gmail.com> (raw)
Add check for the return value of av_malloc_array() to avoid
potential NULL pointer dereference.
Fixes: 4acd08be6c ("ffplay: port to lavu/tx")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
fftools/ffplay.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fftools/ffplay.c b/fftools/ffplay.c
index 2a572fc3aa..12c626c851 100644
--- a/fftools/ffplay.c
+++ b/fftools/ffplay.c
@@ -1156,7 +1156,7 @@ static void video_audio_display(VideoState *s)
err = av_tx_init(&s->rdft, &s->rdft_fn, AV_TX_FLOAT_RDFT,
0, 1 << rdft_bits, &rdft_scale, 0);
}
- if (err < 0 || !s->rdft_data) {
+ if (err < 0 || !s->real_data || !s->rdft_data) {
av_log(NULL, AV_LOG_ERROR, "Failed to allocate buffers for RDFT, switching to waves display\n");
s->show_mode = SHOW_MODE_WAVES;
} else {
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2025-07-14 18:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250714184702.3271-1-jiashengjiangcool@gmail.com \
--to=jiashengjiangcool@gmail.com \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git