From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id EC61D44B24 for ; Mon, 14 Jul 2025 08:51:25 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 157CD68E8B1; Mon, 14 Jul 2025 11:51:22 +0300 (EEST) Received: from haasn.dev (haasn.dev [78.46.187.166]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 5D2DA68E812 for ; Mon, 14 Jul 2025 11:51:15 +0300 (EEST) Received: from haasn.dev (unknown [10.30.1.1]) by haasn.dev (Postfix) with UTF8SMTP id 2C85741A4B; Mon, 14 Jul 2025 10:51:15 +0200 (CEST) Date: Mon, 14 Jul 2025 10:51:15 +0200 Message-ID: <20250714105115.GD56899@haasn.xyz> From: Niklas Haas To: Alexander Strasser via ffmpeg-devel , FFmpeg development discussions and patches In-Reply-To: References: <20250712104459.52153-1-ffmpeg@haasn.xyz> <20250712104459.52153-14-ffmpeg@haasn.xyz> MIME-Version: 1.0 Content-Disposition: inline Subject: Re: [FFmpeg-devel] [PATCH v8 14/18] swscale/ops_memcpy: add 'memcpy' backend for plane->plane copies X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Alexander Strasser Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On Sun, 13 Jul 2025 19:04:21 +0200 Alexander Strasser via ffmpeg-devel wrote: > On 2025-07-12 12:44 +0200, Niklas Haas wrote: > > From: Niklas Haas > > > > Provides a generic fast path for any operation list that can be decomposed > > into a series of memcpy and memset operations. > > > > 25% faster than the x86 backend for yuv444p -> yuva444p > > 33% faster than the x86 backend for gray -> yuvj444p > > --- > > libswscale/Makefile | 1 + > > libswscale/ops.c | 2 + > > libswscale/ops_memcpy.c | 132 ++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 135 insertions(+) > > create mode 100644 libswscale/ops_memcpy.c > > > > diff --git a/libswscale/Makefile b/libswscale/Makefile > > index d3cb7bc555..0fed799542 100644 > > --- a/libswscale/Makefile > > +++ b/libswscale/Makefile > > @@ -18,6 +18,7 @@ OBJS = alphablend.o \ > > ops.o \ > > ops_backend.o \ > > ops_chain.o \ > > + ops_memcpy.o \ > > ops_optimizer.o \ > > options.o \ > > output.o \ > > diff --git a/libswscale/ops.c b/libswscale/ops.c > > index 2d8f9e6084..76423f631e 100644 > > --- a/libswscale/ops.c > > +++ b/libswscale/ops.c > > @@ -28,8 +28,10 @@ > > #include "ops_internal.h" > > > > extern SwsOpBackend backend_c; > > +extern SwsOpBackend backend_murder; > > > > const SwsOpBackend * const ff_sws_op_backends[] = { > > + &backend_murder, > > &backend_c, > > NULL > > }; > > diff --git a/libswscale/ops_memcpy.c b/libswscale/ops_memcpy.c > > new file mode 100644 > > index 0000000000..ef4784faa4 > > --- /dev/null > > +++ b/libswscale/ops_memcpy.c > [...] > > + > > +SwsOpBackend backend_murder = { > > + .name = "memcpy", > > + .compile = compile, > > +}; > > Is this intentional? > While everything is name `memcpy` the variables are namend `_murder`? It's an (IMO) harmless joke. I can remove it if you'd prefer. > > > Alexander > _______________________________________________ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".