From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 8577141000 for ; Sun, 13 Jul 2025 19:27:15 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 4026768E357; Sun, 13 Jul 2025 22:25:45 +0300 (EEST) Received: from btbn.de (btbn.de [144.76.60.213]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 95EFE68E328 for ; Sun, 13 Jul 2025 22:25:27 +0300 (EEST) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id 7A7BC27FD376A; Sun, 13 Jul 2025 21:25:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1752434723; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YtrvXecuInetqHTcBy03iB4Bw6Veuio6cvE4Kue7N7M=; b=P59AX/xiAUrTOPkhKqvKPVXPmcoAuNlyaAdUqA7RYsMniJklWBDZ+aZEHad8Zr+Eu7TW5Q vJW/E3SwOXB9cJKMXpr62uE5G+t4k6iF/kR1duai/4TZDCarBXR09RWy1Z2CbfnKxw8KTz sSaGCPSOjLKpsL+yhbSfuI21rQ3+yGbaGrprNFZa30jC6KpS9/S4b9hCswY8xfrGiNbhvT l4O0SreVLhwhyHofJUqEQASPto5mRELlMei/cG9unZwErE5swIPNGkaKo/aA7VH90T8OOy +Uw1Az6az78Ft4sd0e5CtrbqdeU30vdIyyPeWlsOXnatAEZJgczKoJPyJm+ZdQ== From: Timo Rothenpieler To: ffmpeg-devel@ffmpeg.org Date: Sun, 13 Jul 2025 21:24:41 +0200 Message-ID: <20250713192512.928390-7-timo@rothenpieler.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250713192512.928390-1-timo@rothenpieler.org> References: <20250713192512.928390-1-timo@rothenpieler.org> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 07/14] avformat/tls_openssl: don't hardcode ciphers and curves for dtls X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Timo Rothenpieler Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --- libavformat/tls_openssl.c | 22 ---------------------- 1 file changed, 22 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 8326762592..bb9a5b8054 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -776,15 +776,12 @@ static int dtls_start(URLContext *h, const char *url, int flags, AVDictionary ** TLSShared *c = &p->tls_shared; int ret = 0; c->is_dtls = 1; - const char* ciphers = "ALL"; /** * The profile for OpenSSL's SRTP is SRTP_AES128_CM_SHA1_80, see ssl/d1_srtp.c. * The profile for FFmpeg's SRTP is SRTP_AES128_CM_HMAC_SHA1_80, see libavformat/srtp.c. */ const char* profiles = "SRTP_AES128_CM_SHA1_80"; - /* Refer to the test cases regarding these curves in the WebRTC code. */ - const char* curves = "X25519:P-256:P-384:P-521"; p->ctx = SSL_CTX_new(c->listen ? DTLS_server_method() : DTLS_client_method()); if (!p->ctx) { @@ -792,25 +789,6 @@ static int dtls_start(URLContext *h, const char *url, int flags, AVDictionary ** goto fail; } - /* For ECDSA, we could set the curves list. */ - if (SSL_CTX_set1_curves_list(p->ctx, curves) != 1) { - av_log(p, AV_LOG_ERROR, "TLS: Init SSL_CTX_set1_curves_list failed, curves=%s, %s\n", - curves, openssl_get_error(p)); - ret = AVERROR(EINVAL); - return ret; - } - - /** - * We activate "ALL" cipher suites to align with the peer's capabilities, - * ensuring maximum compatibility. - */ - if (SSL_CTX_set_cipher_list(p->ctx, ciphers) != 1) { - av_log(p, AV_LOG_ERROR, "TLS: Init SSL_CTX_set_cipher_list failed, ciphers=%s, %s\n", - ciphers, openssl_get_error(p)); - ret = AVERROR(EINVAL); - return ret; - } - ret = openssl_init_ca_key_cert(h); if (ret < 0) goto fail; -- 2.49.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".