Re: [FFmpeg-devel] [PATCH v2] avformat/tls_schannel: add check for Windows 10 only types and defines

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] avformat/tls_schannel: add check for Windows 10 only types and defines
Date: Sun, 13 Jul 2025 19:37:49 +0200
Message-ID: <20250713173749.GG29660@pb2> (raw)
In-Reply-To: <20250713162557.8163-1-jamrial@gmail.com>

[-- Attachment #1.1: Type: text/plain, Size: 1720 bytes --]

On Sun, Jul 13, 2025 at 01:25:57PM -0300, James Almer wrote:
> Old Mingw-w64 releases provided by some distros seemingly don't have them, so
> check for them and disable the dtls protocol if unavailable.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  configure                  |  4 ++++
>  libavformat/tls_schannel.c | 29 +++++++++++++++++++++++++++--
>  2 files changed, 31 insertions(+), 2 deletions(-)

fewer errors but still failing:

make -j32 -k
CC	libavformat/tls_schannel.o
src/libavformat/tls_schannel.c: In function ‘tls_handshake_loop’:
src/libavformat/tls_schannel.c:971:25: error: ‘SEC_I_MESSAGE_FRAGMENT’ undeclared (first use in this function)
  971 |         if (sspi_ret == SEC_I_MESSAGE_FRAGMENT) {
      |                         ^~~~~~~~~~~~~~~~~~~~~~
src/libavformat/tls_schannel.c:971:25: note: each undeclared identifier is reported only once for each function it appears in
src/libavformat/tls_schannel.c: In function ‘tls_handshake’:
src/libavformat/tls_schannel.c:1087:21: warning: unused variable ‘sspi_ret’ [-Wunused-variable]
 1087 |     SECURITY_STATUS sspi_ret;
      |                     ^~~~~~~~
At top level:
src/libavformat/tls_schannel.c:1207:12: warning: ‘dtls_open’ defined but not used [-Wunused-function]
 1207 | static int dtls_open(URLContext *h, const char *uri, int flags, AVDictionary **options)
      |            ^~~~~~~~~
make: *** [src/ffbuild/common.mak:81: libavformat/tls_schannel.o] Error 1
make: Target 'all' not remade because of errors.

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No snowflake in an avalanche ever feels responsible. -- Voltaire

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".