From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 005E44E940 for ; Sat, 12 Jul 2025 13:37:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 17F6E68F169; Sat, 12 Jul 2025 16:37:06 +0300 (EEST) Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 60FF068E2CC for ; Sat, 12 Jul 2025 16:37:00 +0300 (EEST) Received: by mail-qv1-f52.google.com with SMTP id 6a1803df08f44-702cbfe860cso29435286d6.1 for ; Sat, 12 Jul 2025 06:37:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752327419; x=1752932219; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=UEJ7EUAOGqmVKBg2CJEheq/er2tYH9Mzo/B2BscHDvU=; b=Ts3eeApVEt/9eS+bNSs6MVFl9UYT/Rh/L2p2nU1F8TgIlGXm8c5NU1VE3pmmsrHj5S 4vzXWKVF1WAiYsMA2mqzJFhne5hn8UpE9MvgxXkTx7VX9FyjuEk53mFX69x8CX0dJChP tUvBbNJiER4z6k7cAnMI5iYZ1OJJkoEUDNxElRE+BdHib6oQ7sZYu+t6o8wrQ6DCZY6V VG82aUEIEujWHREeKGPyTkVFnNpmtZYEUXuLzl4e1EmaGQqomL4PBejOuIsOpx6PHX90 UaW4Xt2aRi3E1QW8vY9fC8gPO/SXsHVKw6demGK77Uz2GWa9rHpUtTFxkQhC+px9fiFL lRZg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752327419; x=1752932219; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UEJ7EUAOGqmVKBg2CJEheq/er2tYH9Mzo/B2BscHDvU=; b=UMsqYGRiXuCTtIKY7XFgg6JxGC/36NR96TKPXyWfJmkv/A453JPfUbV7j3zGmhB0ci ZhiefwLUFareDXT3ePL1gPVTKE9PkYbgLcFUz0Kpi7KI5q5qYix8g/oMhEBiBbWo12Jo aEuXIk1ym/UFLBhV/DUwyb93PbobonGpotdJVVsiH8wLN2AmCYSJPT3J5rHrawqk5/r9 b9SQ8cJt/0BLeG8SJTrSX6N1874Qqr1Hps2esQ+Ld77z+el8DeWgzz1gSsLVGw4xBccy N8QeUBvWZv39MS2kOclWkhJsdbjm/KPlj5ZV/sa5Zkg6PmmtLAPME7MhIHN3oHImcyol TIjw== X-Gm-Message-State: AOJu0Yx3BZ1muIOqYevAKzA/o3XmaXm8pwHR4+ayutbEiOYvwVveZvej 5Kh2aKMkRhX13hAkX0gok0A2CQB5Ej5AKydNKZzvjGj7rJ0fWyx74bnyBZZL2OodH94Vjg== X-Gm-Gg: ASbGncsQ3qN/GeqG4LlVQ5V4fyWq2sdMpF+kPdPpI4CVsSl/jG6xBJBuerC4dNlLk7v cMIrarGY8Yq9psKyMcf3TuCXQRQ0VYrHqtj9EH14eaP6PisvXPHrBipTiXSq3BVfrk+ChYa5+R9 CtvBtNCM7I/P8LjNyVzzOC+YaA9kzvY0DEco647zIDIqmpJw+b+eb6sKUMP3ifg4cY8LkD2nU3M PWQtvz8vpvNY9TGYiLWYNBBaZwlMPnZVsCJxg966FggA4qeaqFK6br284bPE1cr2SynVo81hq0f M4hCFbgMhHvigN9B6wwa59Jv5Ugmt7iGDONqkj++pB9XNRB5F5Ml0nv/+diOKmu3VLP10+YibrF 3LPlrdvISG9krqfdTfIhDE1Q3TlxOylIwshiA72sA2TY= X-Google-Smtp-Source: AGHT+IGS0let0GnaSI5QZd8EcLEmvFDPHieAutjidgyOo8BKdiVDV8buBHHWP2L4ITjCmAe3vf9e7A== X-Received: by 2002:a05:6a21:6b18:b0:21f:53a9:b72c with SMTP id adf61e73a8af0-2318029dae4mr9403068637.38.1752326979226; Sat, 12 Jul 2025 06:29:39 -0700 (PDT) Received: from localhost.localdomain ([123.11.82.155]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b3bbe57dc09sm6854399a12.26.2025.07.12.06.29.36 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sat, 12 Jul 2025 06:29:38 -0700 (PDT) From: Jack Lau X-Google-Original-From: Jack Lau To: ffmpeg-devel@ffmpeg.org Date: Sat, 12 Jul 2025 21:29:10 +0800 Message-ID: <20250712132912.65445-5-jacklau1222@qq.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250712132912.65445-1-jacklau1222@qq.com> References: <20250712132912.65445-1-jacklau1222@qq.com> MIME-Version: 1.0 X-Unsent: 1 Subject: [FFmpeg-devel] [PATCH v3 4/6] WHIP: X509 cert serial number should be positive. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: winlin , Jack Lau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: winlin See RFC5280 4.1.2.2 Co-authored-by: Jack Lau Signed-off-by: winlin --- libavformat/tls_openssl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 2a01fb387d..285ea166ac 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -311,7 +311,8 @@ static int openssl_gen_certificate(EVP_PKEY *pkey, X509 **cert, char **fingerpri goto enomem_end; } - serial = (int)av_get_random_seed(); + // According to RFC5280 4.1.2.2, The serial number MUST be a positive integer + serial = (int)(av_get_random_seed() & 0x7FFFFFFF); if (ASN1_INTEGER_set(X509_get_serialNumber(*cert), serial) != 1) { av_log(NULL, AV_LOG_ERROR, "TLS: Failed to set serial, %s\n", ERR_error_string(ERR_get_error(), NULL)); goto einval_end; -- 2.49.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".