From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id D606E503DB for ; Sat, 12 Jul 2025 10:53:10 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id C79D868F0E9; Sat, 12 Jul 2025 13:53:02 +0300 (EEST) Received: from relay16.mail.gandi.net (relay16.mail.gandi.net [217.70.178.236]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id D0EFF68F0E1 for ; Sat, 12 Jul 2025 13:53:00 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id AB77E438D3 for ; Sat, 12 Jul 2025 10:52:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1752317579; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=VGzhxeERnU1wQlSsKCswzTk91CHf9ENxyBvFrQuvJus=; b=OyHijLq4hX0lNZzUFHyywy3xt6X4MvRXeor7MqJ+ZZK/fbyHPIDUlIFhf3K8DorhfapAWo sDeKXV9FepQUXVsiU1xhEL3SUjTIdxgYChrPZJiB3gp7moeeSmRxqWd2ux0djNzSDQScfU 1/N29aWfjqtY9Zk/oa0t5detc0ILhcVLZs0x0pLZQn4SVCl5OJVBoNV8Mqn9ZErDKAxdi5 yowzw/ByHlU+hM7V+YVwFlVVQ3lC7JOqsK+f542Y+5T3B/lpqqYeOZhFBjw+qLq3kTwGDY OM7mHN+RtCDNPh2ZBgRUsCjazR55hPCgz+CnRYSGZ9ab5uozC42ce03BhL3vDQ== Date: Sat, 12 Jul 2025 12:52:58 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250712105258.GY29660@pb2> References: <20250711095439.332634-1-nicolas.gaullier@cji.paris> <20250711095439.332634-2-nicolas.gaullier@cji.paris> MIME-Version: 1.0 In-Reply-To: <20250711095439.332634-2-nicolas.gaullier@cji.paris> X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdegiedttdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdludehmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeihedrudejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeihedrudejiedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh Subject: Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec/aac_ac3_parser: simplify X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============2203434608053984253==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============2203434608053984253== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="ZFGNZ5O2p+2s2Nq2" Content-Disposition: inline --ZFGNZ5O2p+2s2Nq2 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 11, 2025 at 11:54:29AM +0200, Nicolas Gaullier wrote: > Remove unused USAC/ADTS code: ff_adts_header_parse() parse the > object_type from a 2 bits field. > See also 696ea1c2236842572df88d573e24a39be3f19c98. >=20 > Use ff_adts_header_parse_buf() wrapper to simplify as GetBitContext is > no longer needed (it was introduced for USAC). >=20 > Partially reverts 64bb91fd3b5a00a8849531c7e8dd207f2a626096. >=20 > Signed-off-by: Nicolas Gaullier > --- > libavcodec/aac_ac3_parser.c | 7 +++---- > 1 file changed, 3 insertions(+), 4 deletions(-) >=20 > diff --git a/libavcodec/aac_ac3_parser.c b/libavcodec/aac_ac3_parser.c > index e10ce13a3b..b49ce0277c 100644 > --- a/libavcodec/aac_ac3_parser.c > +++ b/libavcodec/aac_ac3_parser.c > @@ -147,15 +147,14 @@ get_next: > } else { > #if CONFIG_AAC_PARSER > AACADTSHeaderInfo hdr; > - GetBitContext gb; > =20 > - init_get_bits8(&gb, buf, buf_size); > if (buf_size < AV_AAC_ADTS_HEADER_SIZE || > - ff_adts_header_parse(&gb, &hdr) < 0) > + ff_adts_header_parse_buf(buf, &hdr) < 0) > return i; > =20 > avctx->profile =3D hdr.object_type - 1; > - s1->key_frame =3D (avctx->profile =3D=3D AV_PROFILE_AAC_USAC= ) ? get_bits1(&gb) : 1; > + /* ADTS does not support USAC */ > + s1->key_frame =3D 1; > bit_rate =3D hdr.bit_rate; Are these 2 changes related ? if not they are maybe better in 2 seperate patches thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Concerning the gods, I have no means of knowing whether they exist or not or of what sort they may be, because of the obscurity of the subject, and the brevity of human life -- Protagoras --ZFGNZ5O2p+2s2Nq2 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaHI+hwAKCRBhHseHBAsP qxzyAJ44WWYit/Vt4wYmTJ+a13osiIt4YQCeIAtjGBI6qwoSQSLg70mwglQZ3GA= =5/Nh -----END PGP SIGNATURE----- --ZFGNZ5O2p+2s2Nq2-- --===============2203434608053984253== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============2203434608053984253==--