Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Niklas Haas <ffmpeg@haasn.xyz>
To: ffmpeg-devel@ffmpeg.org
Cc: Niklas Haas <git@haasn.dev>
Subject: [FFmpeg-devel] [PATCH 2/4] tests/checkasm: add scene_sad checkasm test
Date: Sat, 12 Jul 2025 11:22:41 +0200
Message-ID: <20250712092243.29138-2-ffmpeg@haasn.xyz> (raw)
In-Reply-To: <20250712092243.29138-1-ffmpeg@haasn.xyz>

From: Niklas Haas <git@haasn.dev>

---
 tests/checkasm/Makefile    |  1 +
 tests/checkasm/checkasm.c  |  3 ++
 tests/checkasm/checkasm.h  |  1 +
 tests/checkasm/scene_sad.c | 73 ++++++++++++++++++++++++++++++++++++++
 4 files changed, 78 insertions(+)
 create mode 100644 tests/checkasm/scene_sad.c

diff --git a/tests/checkasm/Makefile b/tests/checkasm/Makefile
index afd62d95ba..1938468bbd 100644
--- a/tests/checkasm/Makefile
+++ b/tests/checkasm/Makefile
@@ -52,6 +52,7 @@ AVCODECOBJS-$(CONFIG_VVC_DECODER)       += vvc_alf.o vvc_mc.o vvc_sao.o
 CHECKASMOBJS-$(CONFIG_AVCODEC)          += $(AVCODECOBJS-yes)
 
 # libavfilter tests
+AVFILTEROBJS-$(CONFIG_SCENE_SAD)         += scene_sad.o
 AVFILTEROBJS-$(CONFIG_AFIR_FILTER) += af_afir.o
 AVFILTEROBJS-$(CONFIG_BLEND_FILTER) += vf_blend.o
 AVFILTEROBJS-$(CONFIG_BWDIF_FILTER)      += vf_bwdif.o
diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c
index f4e3d4f433..66a8f8ff86 100644
--- a/tests/checkasm/checkasm.c
+++ b/tests/checkasm/checkasm.c
@@ -260,6 +260,9 @@ static const struct {
     #endif
 #endif
 #if CONFIG_AVFILTER
+    #if CONFIG_SCENE_SAD
+        { "scene_sad", checkasm_check_scene_sad },
+    #endif
     #if CONFIG_AFIR_FILTER
         { "af_afir", checkasm_check_afir },
     #endif
diff --git a/tests/checkasm/checkasm.h b/tests/checkasm/checkasm.h
index e829942d58..825e7ef52f 100644
--- a/tests/checkasm/checkasm.h
+++ b/tests/checkasm/checkasm.h
@@ -124,6 +124,7 @@ void checkasm_check_pixblockdsp(void);
 void checkasm_check_sbrdsp(void);
 void checkasm_check_rv34dsp(void);
 void checkasm_check_rv40dsp(void);
+void checkasm_check_scene_sad(void);
 void checkasm_check_svq1enc(void);
 void checkasm_check_synth_filter(void);
 void checkasm_check_sw_gbrp(void);
diff --git a/tests/checkasm/scene_sad.c b/tests/checkasm/scene_sad.c
new file mode 100644
index 0000000000..bc33c428c6
--- /dev/null
+++ b/tests/checkasm/scene_sad.c
@@ -0,0 +1,73 @@
+/*
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License as published by
+ * the Free Software Foundation; either version 2 of the License, or
+ * (at your option) any later version.
+ *
+ * FFmpeg is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License along
+ * with FFmpeg; if not, write to the Free Software Foundation, Inc.,
+ * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+ */
+
+#include "checkasm.h"
+#include "libavfilter/scene_sad.h"
+#include "libavutil/mem_internal.h"
+
+#define WIDTH  256
+#define HEIGHT 256
+#define STRIDE WIDTH
+
+#define randomize_buffers(type, buf, size, mask)  \
+    do {                                          \
+        int j;                                    \
+        type *tmp_buf = (type *) buf;             \
+        for (j = 0; j < size; j++)                \
+            tmp_buf[j] = rnd() & mask;            \
+    } while (0)
+
+static void check_scene_sad(int depth)
+{
+    LOCAL_ALIGNED_32(uint8_t, src1, [WIDTH * HEIGHT * 2]);
+    LOCAL_ALIGNED_32(uint8_t, src2, [WIDTH * HEIGHT * 2]);
+    declare_func(void, const uint8_t *src1, ptrdiff_t stride1,
+                       const uint8_t *src2, ptrdiff_t stride2,
+                       ptrdiff_t width, ptrdiff_t height, uint64_t *sum);
+
+    const int width = WIDTH >> (depth > 8);
+    int mask = (1 << depth) - 1;
+    if (depth <= 8) {
+        randomize_buffers(uint8_t,  src1, width * HEIGHT, mask);
+        randomize_buffers(uint8_t,  src2, width * HEIGHT, mask);
+    } else if (depth <= 16) {
+        randomize_buffers(uint16_t, src1, width * HEIGHT, mask);
+        randomize_buffers(uint16_t, src2, width * HEIGHT, mask);
+    }
+
+    if (check_func(ff_scene_sad_get_fn(depth), "scene_sad%d", depth)) {
+        uint64_t sum1, sum2;
+        call_ref(src1, STRIDE, src2, STRIDE, width, HEIGHT, &sum1);
+        call_new(src1, STRIDE, src2, STRIDE, width, HEIGHT, &sum2);
+        if (sum1 != sum2) {
+            fprintf(stderr, "scene_sad%d: sum mismatch: %llu != %llu\n",
+                    depth, (unsigned long long) sum1, (unsigned long long) sum2);
+            fail();
+        }
+        bench_new(src1, STRIDE, src2, STRIDE, WIDTH, HEIGHT, &sum2);
+    }
+}
+
+void checkasm_check_scene_sad(void)
+{
+    const int depths[] = { 8, 10, 12, 14, 15, 16 };
+    for (int i = 0; i < FF_ARRAY_ELEMS(depths); i++) {
+        check_scene_sad(depths[i]);
+        report("scene_sad%d", depths[i]);
+    }
+}
-- 
2.49.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2025-07-12  9:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-12  9:22 [FFmpeg-devel] [PATCH 1/4] avfilter/scene_sad: pass true depth to ff_scene_sad_get_fn() Niklas Haas
2025-07-12  9:22 ` Niklas Haas [this message]
2025-07-12  9:22 ` [FFmpeg-devel] [PATCH 3/4] avfilter/x86/scene_sad: add AVX512 implementation Niklas Haas
2025-07-12  9:22 ` [FFmpeg-devel] [PATCH 4/4] avfilter/x86/scene_sad: add high bit depth AVX2/AVX512 version Niklas Haas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250712092243.29138-2-ffmpeg@haasn.xyz \
    --to=ffmpeg@haasn.xyz \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=git@haasn.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git