From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 10E0E4E7D4 for ; Fri, 11 Jul 2025 21:17:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 5554269022A; Sat, 12 Jul 2025 00:17:41 +0300 (EEST) Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 66A3A68F58D for ; Sat, 12 Jul 2025 00:17:35 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 8949B443A6 for ; Fri, 11 Jul 2025 21:17:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1752268654; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=qvxjqobNVbcxp9C/fNzgMQxWFCYEjno07JfdcJzZZyY=; b=ULrdO3mqeReE7E+2cI25+zNf5jSH9ogVUvufXqLjNJnSPFmeNoOkMRHFvxZnXf93Myjm5n 1u7Vmv1fdUDiefWDOU7la8dfDb/WyA+SgzqYxjBJkYSqcw1hSSbCzifi40psrwEcEgZ2Em 4HCeOauKzxzso6eR7QdRWzfYvSptwJbyUUOtF2BthngMpsigWr8JdjJzE6xTEgkxzK3eCJ cxr+ztpdVUOWXkT+JNEfSiyAmBiXUvI6wMaCvKxUGhfMn1L7Di0blLL0FoGNDp6IQoPJWU Vs6dfucx+/bwZrNowdYkcFWYGwnU3jMu4W/7WBWLwLD9xbFXd/iUva+bhe1SiA== Date: Fri, 11 Jul 2025 23:17:33 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250711211733.GT29660@pb2> References: <20250707103102.3477457-1-michael@niedermayer.cc> <20250707103102.3477457-2-michael@niedermayer.cc> <20250707145833.GG29660@pb2> <20250707200731.GH29660@pb2> <20250710233654.GS29660@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdeggeefkecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlfedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeihedrudejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeihedrudejiedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============0531280609223852571==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============0531280609223852571== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="OG1YDW0fyIXPKhXU" Content-Disposition: inline --OG1YDW0fyIXPKhXU Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 11, 2025 at 10:29:30AM +0200, Nicolas George wrote: > Michael Niedermayer (HE12025-07-11): > > ok, chanegd it to AVERROR_INVALIDDATA >=20 > Thanks. >=20 > > Yes > > but this also affects releases, and adding a field to AVFormatContext > > is an issue for releases as it changes ABI > >=20 > > So the concat patch would go into old release branches and the > > AVFormatContext one into master > > Unless someone has a better idea ... >=20 > What happened to being able to add fields at the end? a release branch might have a libavformat with version 1.2.3 the next release branch might have a libavformat with version 1.5.2 The problem is if we add a field to 1.2.3 (which would become 1.3.0) ABI/API requires that field to be in 1.5.2, but it is not Also besides this problem, 1.3.0 on git masters history likely added something thats not on the release branches 1.3.0 So, adding at the end is perfectly fine on the linear history on git master but our release branches, branch off that. so we would have to hack around things if we really needed to add a field, we could try to use 1.2.4 or even 1.2.3 with a new field but this is wrong. thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Observe your enemies, for they first find out your faults. -- Antisthenes --OG1YDW0fyIXPKhXU Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaHF/aQAKCRBhHseHBAsP q4b9AKCN45f5pQNexQ84xxp34E1ih/9CZgCgmyQx5CQ1KqTuX0OWsIkId+Q9huk= =6Tgt -----END PGP SIGNATURE----- --OG1YDW0fyIXPKhXU-- --===============0531280609223852571== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============0531280609223852571==--