From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 6827B4E5AD for ; Thu, 10 Jul 2025 19:42:04 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 77F3B68FAD1; Thu, 10 Jul 2025 22:42:00 +0300 (EEST) Received: from mail-yw1-f179.google.com (mail-yw1-f179.google.com [209.85.128.179]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 0551C68E7A6 for ; Thu, 10 Jul 2025 22:41:54 +0300 (EEST) Received: by mail-yw1-f179.google.com with SMTP id 00721157ae682-7179205a439so14175187b3.1 for ; Thu, 10 Jul 2025 12:41:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752176512; x=1752781312; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=DmozmuUkACyg0hLRpu88IzB0BwByZAz1w19rmptOHXg=; b=TpNtFRcw6zSVrkeJ5CNRbsfNXCl92k4SstV2ly5qVFVNVhJKsgbaw/BRDTnBzEFo6O pI8m5pEA03bxfZL312ryQQpFYMXlVWxwP+V2wNxQXKRA8NPQiGGa2zt6JH8Bz/1jZe5a CS4Hbj/kvTPpzT+snHbCfiIqECCYL3xbIVNXkvBrEdvsZV4atHj49uhFk+qy6xVTpxQi MzX0nCoxZ3M3xR+Cv5jHRE5Ln0hq/jZWnwGE7OHlHqfxojRUMfvO2f2ZfkqsG9JqoJnZ WV0BiPt+SjTzx2IltkUYjjG+BXQc6ngghPLruZPlv2MFzzWdn5DAIUw5zg9aU6Q43vuY m21Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752176512; x=1752781312; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DmozmuUkACyg0hLRpu88IzB0BwByZAz1w19rmptOHXg=; b=NUW868d4Nkg1FDqDAU25MR7lwR/1j4wwsdBC7flvCAVXnSVxllASas2vK25PaYwENG YhMv1eeK2gLQ62DQE1EXMzPb/FjcdrOF/Q9ox6cngtyr65s7zWdJ2ywwcerd3WJg4Unx t3BkS17pbG5fU9UjBfSq9dosmN2YDk6NuTsIoQXmNE41bpWUo7Qvxhrr1UbAoY34JrDW 9vMkYI1d93rYQwr3EG1dMAhF2rG3dYp/QvnrXsYDbQFOtpOAxcHaF6ihzRySk34YP2BT nryjHicFzQwxA4rvwhsZIMUefYj64BzSaKSn2orCHhxMGyfJUmt4J85rwZyu0+4V/eAr 13Lg== X-Gm-Message-State: AOJu0YweSpEkNSY4mb0iZQPNBiWtS3JLXfitk0CfnkcvpHGHCU4U8Lps NSYBTYTsuG23OuElCPIl0tHUxpGDQtixoo7keVy8BuYwDAhPMQpqxbELaLfOCg== X-Gm-Gg: ASbGncsugcIFv7XUkVJfV82WC/WjaQlHQUpMLgHCORbIeYTiVaO4sP62iwEsMCud43Z 1RqvYrGFvHaZLmKVDNHM0H2NmAfZjSCxSw/lhNS5JQX4EW/6NdoEW/DzaxyCqlOApMtWCpmTSGX 47ucyE7F5wQJUXMn0SWr6hU3yyf+oXLXVQ1O+E/50Ro/DPlG6kfAvpT5VsuSii6E2zylk1ed2se d1QikRi61FhK3criK3TxeQsVeaNQnSa19b6lLp2cFNzF6HOp2KnaiB+Q3leCaXU7ejfWZgdbTB8 Bl6D0laT9MZZLdUh0OmqI0NY2okhh/ezmFHJqwPqj7VrqQEkbID3ylCoBk5QJor8HuuQRC0/FiU ijwOc13+8 X-Google-Smtp-Source: AGHT+IFz+ouyGE0toOcRT5rQbdNTt9m6HIQ0YJNMfDTKSFOeMzDq9pyWq8z0NRlg71PPgpjtLZevfQ== X-Received: by 2002:a05:690c:6504:b0:713:ffaa:5767 with SMTP id 00721157ae682-717c14ac1e5mr75259617b3.7.1752176512115; Thu, 10 Jul 2025 12:41:52 -0700 (PDT) Received: from newman.cs.purdue.edu ([128.10.127.250]) by smtp.gmail.com with ESMTPSA id 00721157ae682-717c61b4cdbsm4233947b3.65.2025.07.10.12.41.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 12:41:51 -0700 (PDT) From: Jiasheng Jiang To: ffmpeg-devel@ffmpeg.org Date: Thu, 10 Jul 2025 19:41:49 +0000 Message-Id: <20250710194149.27218-1-jiashengjiangcool@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] fftools/cmdutils: Add av_freep() to avoid memory leak X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jiasheng Jiang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Add av_freep() to free new_elem to avoid memory leak. Fixes: 2d0bfbd0fa ("fftools/cmdutils: Use av_dynarray_add_nofree()") Signed-off-by: Jiasheng Jiang --- fftools/cmdutils.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c index e442935cae..5c8d09f87a 100644 --- a/fftools/cmdutils.c +++ b/fftools/cmdutils.c @@ -1471,9 +1471,13 @@ void *allocate_array_elem(void *ptr, size_t elem_size, int *nb_elems) { void *new_elem; - if (!(new_elem = av_mallocz(elem_size)) || - av_dynarray_add_nofree(ptr, nb_elems, new_elem) < 0) + new_elem = av_mallocz(elem_size); + if (!new_elem) return NULL; + if (av_dynarray_add_nofree(ptr, nb_elems, new_elem) < 0) { + av_freep(&new_elem); + return NULL; + } return new_elem; } -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".