Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
* [FFmpeg-devel] [PATCH] libavcodec/sonic.c: Add check for av_calloc()
@ 2025-07-10 18:43 Jiasheng Jiang
  0 siblings, 0 replies; only message in thread
From: Jiasheng Jiang @ 2025-07-10 18:43 UTC (permalink / raw)
  To: ffmpeg-devel; +Cc: Jiasheng Jiang

Add check for the return value of av_calloc() to avoid
potential NULL pointer dereference.

Fixes: 54f5fd22ea ("new opensource lossy/lossless audio codec based on speech compression techniques (actually based on bonk)")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
 libavcodec/sonic.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libavcodec/sonic.c b/libavcodec/sonic.c
index 8b1d092ec9..d7610ea5ed 100644
--- a/libavcodec/sonic.c
+++ b/libavcodec/sonic.c
@@ -950,6 +950,8 @@ static av_cold int sonic_decode_init(AVCodecContext *avctx)
         s->tap_quant[i] = ff_sqrt(i+1);
 
     s->predictor_k = av_calloc(s->num_taps, sizeof(*s->predictor_k));
+    if (!s->predictor_k)
+        return AVERROR(ENOMEM);
 
     tmp = av_calloc(s->num_taps, s->channels * sizeof(**s->predictor_state));
     if (!tmp)
-- 
2.25.1

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2025-07-10 18:44 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-10 18:43 [FFmpeg-devel] [PATCH] libavcodec/sonic.c: Add check for av_calloc() Jiasheng Jiang

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git