From: Jiasheng Jiang <jiashengjiangcool-at-gmail.com@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: Jiasheng Jiang <jiashengjiangcool@gmail.com>
Subject: [FFmpeg-devel] [PATCH] libavcodec/sonic.c: Add check for av_calloc()
Date: Thu, 10 Jul 2025 18:43:55 +0000
Message-ID: <20250710184355.14596-1-jiashengjiangcool@gmail.com> (raw)
Add check for the return value of av_calloc() to avoid
potential NULL pointer dereference.
Fixes: 54f5fd22ea ("new opensource lossy/lossless audio codec based on speech compression techniques (actually based on bonk)")
Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
---
libavcodec/sonic.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/sonic.c b/libavcodec/sonic.c
index 8b1d092ec9..d7610ea5ed 100644
--- a/libavcodec/sonic.c
+++ b/libavcodec/sonic.c
@@ -950,6 +950,8 @@ static av_cold int sonic_decode_init(AVCodecContext *avctx)
s->tap_quant[i] = ff_sqrt(i+1);
s->predictor_k = av_calloc(s->num_taps, sizeof(*s->predictor_k));
+ if (!s->predictor_k)
+ return AVERROR(ENOMEM);
tmp = av_calloc(s->num_taps, s->channels * sizeof(**s->predictor_state));
if (!tmp)
--
2.25.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
reply other threads:[~2025-07-10 18:44 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250710184355.14596-1-jiashengjiangcool@gmail.com \
--to=jiashengjiangcool-at-gmail.com@ffmpeg.org \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=jiashengjiangcool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git