From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9E24F502E7 for ; Thu, 10 Jul 2025 16:20:52 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id E96B168FFBC; Thu, 10 Jul 2025 19:20:45 +0300 (EEST) Received: from mail-yw1-f172.google.com (mail-yw1-f172.google.com [209.85.128.172]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 9B23868FFA3 for ; Thu, 10 Jul 2025 19:20:37 +0300 (EEST) Received: by mail-yw1-f172.google.com with SMTP id 00721157ae682-70f94fe1e40so25961977b3.1 for ; Thu, 10 Jul 2025 09:20:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752164436; x=1752769236; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=PaYM3KMptdfnLf8SEFvrXLpb2e6yItFRI10+aEfD3Gg=; b=HkDBLoVHinnzftLrFl7cYz7977gW4KX//rZn6YuWV+V9x8YAzlMD+u09NDLJ/fVULz BwlhpPcX5tqM/U5Ao1Fi0T0JZSjqQL0qRGv8OE1pj7rC39I4R1NwvphUQdZbLmSYjoGx zcBMgaO9OdhZWu+4Y+bKZBBE6MyMXPqoFBk+LMQxYMcqFg7EjgmFePWhLFQ3cpWASC1b Ph66hSg1hyN6UCqT/hpQN27n+b6ZAUnSN8jqwA4lQ3kBbXXxV64b54htejNvx85CRKqe D43GuYA/ZWeWTVFHMS6ocMIjI14eRTgxkPtt7b0svNoFi7p44zGI8PoGlRcxuUPvaPf8 oFbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752164436; x=1752769236; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=PaYM3KMptdfnLf8SEFvrXLpb2e6yItFRI10+aEfD3Gg=; b=eZKMjTCMLH4aBEZkjnySv1xg5OVu4Ye6vJD9o4Nx/k26abOIgBoz1/tmzGNt3jw3uy zkyaHBEorraXevSuOLhdqkD6uPuICqDq50RR8XNe6knP6QZMYLSEDSiT2x/W8MFaiGc5 mjRevRMWYcdk8num5RsBbBL/DxcjUqUgH4D+xIkqZLi84FCixSlFXXksa4yDlahPkFSb Gla7rkYh0NTD7MrilCFtxrDvtlIsKNESIRlDvRWa7qbdcKAv/1TIwk/muwNSE7NzuLTW rEPUUqPu7EHOjx+AgE1nZ+Oym6QgdeyFl0XI57bAI2m49OKvIsC7dxoLjkVSUl7dNyKV VIrQ== X-Gm-Message-State: AOJu0YzE6T4kxkA1lcEyWejYcqnHSWLDYnmECQM9uho3PBEwhewCbZoJ 0VSxi3Ba72ZW+KleQCGYouLvkrMMBIHg2/20ywfa2CYMepa4k+KxmrlI1Y9njw== X-Gm-Gg: ASbGncvSFiM2w40r4qXuCISJiik4xjmnKhk4ehvIdyfMUelA9Sk6ekHw95Y6l2yY9eM ZfG4BxObXxX3zj6PHxnCgAS5RFAsKJrnu7d1vDm/weuvEkItEyJEJ6SglKb38XajuW8nrVAyWhJ WtHPh6UOhYue3aKx2fLW95R3BAjgM10Xm/Y6kO6kePSZEhfwRuCCs+01otwJ//dCjcKXsz5g7N7 Yywyvdd8Df83IuGeXurfjpjaRayuMl944Pm74xv2r1vBvfjTgtq5RF6QY4CCzKEdbdy56m15F01 lYQOUAceiHzx2FVTPaVVK3WjLmEmS43q9QLBzRO+alJ+qcYfgpG2Q6IfTpcQlkDntR31cAHhMIa wCWLze5nUuGpD1rYZ1Ew= X-Google-Smtp-Source: AGHT+IEgkFfYm9rRtwmkyisAUklymCO7bZeSCNh3S7loscdL1CLHA5NqndfEaiW+7EIpybXzVhs/Sg== X-Received: by 2002:a05:690c:6504:b0:713:ffaa:5767 with SMTP id 00721157ae682-717c14ac1e5mr63354067b3.7.1752164435609; Thu, 10 Jul 2025 09:20:35 -0700 (PDT) Received: from newman.cs.purdue.edu ([128.10.127.250]) by smtp.gmail.com with ESMTPSA id 00721157ae682-717c5d6bbbesm3526627b3.26.2025.07.10.09.20.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 10 Jul 2025 09:20:34 -0700 (PDT) From: Jiasheng Jiang To: ffmpeg-devel@ffmpeg.org Date: Thu, 10 Jul 2025 16:20:32 +0000 Message-Id: <20250710162032.47489-1-jiashengjiangcool@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] libavcodec/alsdec.c: Add check for av_malloc_array() and av_calloc() X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Jiasheng Jiang Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Add check for the return value of av_malloc_array() and av_calloc() to avoid potential NULL pointer dereference. Fixes: dcfd24b10c ("avcodec/alsdec: Implement floating point sample data decoding") Signed-off-by: Jiasheng Jiang --- libavcodec/alsdec.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c index 734eec8bf8..108167563e 100644 --- a/libavcodec/alsdec.c +++ b/libavcodec/alsdec.c @@ -2119,7 +2119,7 @@ static av_cold int decode_init(AVCodecContext *avctx) ctx->nbits = av_malloc_array(ctx->cur_frame_length, sizeof(*ctx->nbits)); ctx->mlz = av_mallocz(sizeof(*ctx->mlz)); - if (!ctx->mlz || !ctx->acf || !ctx->shift_value || !ctx->last_shift_value + if (!ctx->larray || !ctx->nbits || !ctx->mlz || !ctx->acf || !ctx->shift_value || !ctx->last_shift_value || !ctx->last_acf_mantissa || !ctx->raw_mantissa) { av_log(avctx, AV_LOG_ERROR, "Allocating buffer memory failed.\n"); return AVERROR(ENOMEM); @@ -2132,6 +2132,10 @@ static av_cold int decode_init(AVCodecContext *avctx) for (c = 0; c < channels; ++c) { ctx->raw_mantissa[c] = av_calloc(ctx->cur_frame_length, sizeof(**ctx->raw_mantissa)); + if (!ctx->raw_mantissa[c]) { + av_log(avctx, AV_LOG_ERROR, "Allocating buffer memory failed.\n"); + return AVERROR(ENOMEM); + } } } -- 2.25.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".