From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 66FD050298 for ; Thu, 10 Jul 2025 11:31:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3399F68FBE6; Thu, 10 Jul 2025 14:31:38 +0300 (EEST) Received: from relay3-d.mail.gandi.net (relay3-d.mail.gandi.net [217.70.183.195]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 1139768F8BF for ; Thu, 10 Jul 2025 14:31:36 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 176E11FCE3 for ; Thu, 10 Jul 2025 11:31:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1752147096; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=LFHstCwW5eX++5nG9YZvakd01O3AnE1e6X6gU4N9Noo=; b=Hq92SxlO4ASkkYLzcu8LsTswbJ4vZ+cBf2RRupng7NcJyNWjuowHciDLjOxFdvIVxFD7vG eMRti5MlcL0sS46dGG2yEeC5uAQxVm6wCFk4oA8JurayRViH5E3KJ6o+oTbVdLrnbEUe5X lud+nUXLs01Md6B8pv7PIfQQ63x0XT9QG6Pr7jtHGN/401CrKWARfBNh7lYNpF2izMDbQn ZFOnbLD5QTgTnmh281ik1f8yCcvt5I5FVps+1TYY6fCGjqnjps3KCn+B3M8O/PYhOkR83G 8TWSnWg6KqYlHg7P1+mmjin3iXjk2Z0YwysAhuFkQ1kkA+hkInhO1F1HS9CBrA== Date: Thu, 10 Jul 2025 13:31:34 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250710113134.GO29660@pb2> References: <20250709072350.578693-1-vpalmisano@gmail.com> <20250709233746.GM29660@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgdegtdefvdcutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlfedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeihedrudejieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeihedrudejiedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] Whisper audio filter X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============6331510892844580307==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============6331510892844580307== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="X2pySjZOu28v3e1K" Content-Disposition: inline --X2pySjZOu28v3e1K Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Thu, Jul 10, 2025 at 10:34:50AM +0200, Vittorio Palmisano wrote: > Thanks Michael, I will try to answer your comments. >=20 > > > +ffmpeg -i input.mp4 -vn -af "aformat=3Dsample_rates=3D16000:channel_= layouts=3Dmono,whisper=3D > > > > Is there a reason why we convert to 16khz mono here ? >=20 > It is the only format supported by the whisper.cpp library. then af_whisper should take care of this automatically. without the user having to add this convertion stuff manually [...] >=20 > > libavfilter/af_whisper.c:75:49: error: parameter name omitted > > 75 | static void cb_log_disable(enum ggml_log_level, const char *, v= oid *) {} > > | ^~~~~~~~~~~~ > > libavfilter/af_whisper.c:75:63: >=20 > I don't see this error using the gcc13 compiler. Do you use a > different compiler or some other flags? gcc (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0 >=20 > > > + wctx->audio_buffer_fill_size =3D 0; > > > + > > > + wctx->next_pts =3D AV_NOPTS_VALUE; > > > + > > > + wctx->avio_context =3D NULL; > > > > arent things already initialized to 0 ? >=20 > Yes, maybe we can keep the AV_NOPTS_VALUE assignment (it is not zero). yes thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB The worst form of inequality is to try to make unequal things equal. -- Aristotle --X2pySjZOu28v3e1K Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaG+kjQAKCRBhHseHBAsP qxrJAJ9/8ieY9Sr0sr2x7JDmCp1nBk0erACfav+33Tl3pJirFKW1QBrEhCpQYEA= =NVFY -----END PGP SIGNATURE----- --X2pySjZOu28v3e1K-- --===============6331510892844580307== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============6331510892844580307==--