Re: [FFmpeg-devel] [PATCH] Whisper audio filter

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1390 bytes --]

Hi

On Thu, Jul 10, 2025 at 10:34:50AM +0200, Vittorio Palmisano wrote:
> Thanks Michael, I will try to answer your comments.
> 
> > > +ffmpeg -i input.mp4 -vn -af "aformat=sample_rates=16000:channel_layouts=mono,whisper=
> >
> > Is there a reason why we convert to 16khz mono here ?
> 
> It is the only format supported by the whisper.cpp library.

then af_whisper should take care of this automatically.
without the user having to add this convertion stuff manually


[...]

> 
> > libavfilter/af_whisper.c:75:49: error: parameter name omitted
> >    75 | static void cb_log_disable(enum ggml_log_level, const char *, void *) {}
> >       |                                                 ^~~~~~~~~~~~
> > libavfilter/af_whisper.c:75:63:
> 
> I don't see this error using the gcc13 compiler. Do you use a
> different compiler or some other flags?

gcc (Ubuntu 9.4.0-1ubuntu1~20.04.2) 9.4.0


> 
> > > +    wctx->audio_buffer_fill_size = 0;
> > > +
> > > +    wctx->next_pts = AV_NOPTS_VALUE;
> > > +
> > > +    wctx->avio_context = NULL;
> >
> > arent things already initialized to 0 ?
> 
> Yes, maybe we can keep the AV_NOPTS_VALUE assignment (it is not zero).

yes

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

The worst form of inequality is to try to make unequal things equal.
-- Aristotle

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".