From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 3A80E50145 for ; Tue, 8 Jul 2025 18:15:50 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id DC53168E1D1; Tue, 8 Jul 2025 21:15:47 +0300 (EEST) Received: from mail-ej1-f48.google.com (mail-ej1-f48.google.com [209.85.218.48]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 2291468E1D1 for ; Tue, 8 Jul 2025 21:15:41 +0300 (EEST) Received: by mail-ej1-f48.google.com with SMTP id a640c23a62f3a-ae3c5f666bfso765704866b.3 for ; Tue, 08 Jul 2025 11:15:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751998540; x=1752603340; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=BRhllbhO45zvEvnEypEMpZpGB/pv5xhQGz1IcSVXxRE=; b=SXFZhUMePvPA+wBluH+p8uFm0cGX+/gUxq3HIhcBvknXh7wEAl+wsOl6D+Y/xkJcYR wLnwSP5KbPJlCEC92S3kRPIoBHclxi7g99NNAt6f8xrTYtJoim1eKDEZE2SkG5zKdP8G CVCsI8ovRAsBsr4C+fo2yA/Tl9cMpxbxXRp0UY2TsXIpMm8z+/Y7kOtn0NRyPPpk0/eg lTMQU1+PkKNjwzMzlTZp+h6oPVkuTIxn6obLFNzUJR+Y26sV9ddyk5eIH0Yu2pqZvSEs 3JsvZwT7hEj3D+HK4HPBIe3wjHsyzMuxs9nTtfrin/weNIjUrCYAs63eh7JwmpNi0Iqc PQ8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751998540; x=1752603340; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BRhllbhO45zvEvnEypEMpZpGB/pv5xhQGz1IcSVXxRE=; b=nA2GVkzwozXuRkR2oWVXRWmQ9qJdqshmO3TQldYDhCB9diwTdelljEbLEX1t+d129f /cOIG1QktZEvcIwSVgj2uIZ3+mAWB8AMj1dcMgcDxgSgce/zqSh0HW/wChh9JpaqTCov qzTVUnT4si1x6+jNK3M1iUrisTPIk3FHQfjPN/sbhH2ckvPyygpwpQqblpaMZhLGOi+9 JAkYrrCjhvYDrGm7KmF8ERf20GjBgZV4rg8/0yK038xTsJWQG+1oygXiJ+IXatEoRIBW F/Y6ylE5FtZwzG9ia2iJ1jhm8NdYPexqcSzoghSL/wIj9oh+XUYkZMeNQc8Qcqsvbmfh m9bA== X-Gm-Message-State: AOJu0YxQ3Cc/VqlgkPGLN+62Gkwkga8z17ZdDXcI3Y9ug/XOgna89uSV 9r/BIwPhGnv279HO3gDbmkNj2TrmNRzZEljLlMpIdeZndG5X6PgW+hXS8b0P/Otr X-Gm-Gg: ASbGncuYE1fmMud/LeMK9AS4IYrC1hSB5Rx+jNFDSQcTAE/DalQV5Sv6xci7yv2QhxX lIbJcWphjaMo7Mhuhv9tXlPmPOm6Eo4BXwDaOLAjQhn6u4FEl5YRbymPqd40yGnYqRmmTFAFX5G ZrusqWm6SXW4e7DXIo48hmEk2UBQbVjrdvI8OxxaQzEbNjRFvKCCqFmRXR+RNvNC11iX0l+YTNR tYMtPfPYc6vp3r1wLrKXBFr7aAvLRWkiZZORpE5TNnJeAS3yM8veaQEh70Q8LeuFRt17LofqQjT aRq/mlRAi1BBCvrx6/o+HLSta+B1n7SkxIpmiEf8wyLY48P0oTx6bn3CQIFhuB2ayDa7SIyhfAI M8b1HEnciUPXTIGn6NyUm/vdCObL6vNhp61kwtDgrP9fipNA1TEVoUKSyfxyH/Aq6ISlpe2W/F8 xCCyFpxg== X-Google-Smtp-Source: AGHT+IE/So8q1fZ6jjUajMNaFj0hr2UvNZBVvxHudBzDcPNHIyvoeD/4G0weU2jFCw8RlZbAg24czQ== X-Received: by 2002:a17:906:6a10:b0:ae6:abe9:8cbc with SMTP id a640c23a62f3a-ae6c6acd547mr34461466b.12.1751998540207; Tue, 08 Jul 2025 11:15:40 -0700 (PDT) Received: from localhost.localdomain (p200301023701fa00258573ace0251429.dip0.t-ipconnect.de. [2003:102:3701:fa00:2585:73ac:e025:1429]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ae3f6949fa6sm946603466b.68.2025.07.08.11.15.39 for (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Tue, 08 Jul 2025 11:15:39 -0700 (PDT) From: Marvin Scholz To: ffmpeg-devel@ffmpeg.org Date: Tue, 8 Jul 2025 20:15:32 +0200 Message-Id: <20250708181532.60440-1-epirat07@gmail.com> X-Mailer: git-send-email 2.39.5 (Apple Git-154) MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avformat/rtsp: fix leak of options dict on error X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Fix CID 1655306 --- libavformat/rtsp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 8d360b375f..0810c56a8b 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -1847,6 +1847,7 @@ redirect: /* GET requests */ if (ffurl_alloc(&rt->rtsp_hd, httpname, AVIO_FLAG_READ, &s->interrupt_callback) < 0) { + av_dict_free(&options); err = AVERROR(EIO); goto fail; } @@ -1863,6 +1864,7 @@ redirect: if (!rt->rtsp_hd->protocol_whitelist && s->protocol_whitelist) { rt->rtsp_hd->protocol_whitelist = av_strdup(s->protocol_whitelist); if (!rt->rtsp_hd->protocol_whitelist) { + av_dict_free(&options); err = AVERROR(ENOMEM); goto fail; } @@ -1878,6 +1880,7 @@ redirect: /* POST requests */ if (ffurl_alloc(&rt->rtsp_hd_out, httpname, AVIO_FLAG_WRITE, &s->interrupt_callback) < 0 ) { + av_dict_free(&options); err = AVERROR(EIO); goto fail; } -- 2.39.5 (Apple Git-154) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".