From: Marvin Scholz <epirat07-at-gmail.com@ffmpeg.org> To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [PATCH] avformat/rtsp: fix leak of options dict on error Date: Tue, 8 Jul 2025 20:15:32 +0200 Message-ID: <20250708181532.60440-1-epirat07@gmail.com> (raw) Fix CID 1655306 --- libavformat/rtsp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c index 8d360b375f..0810c56a8b 100644 --- a/libavformat/rtsp.c +++ b/libavformat/rtsp.c @@ -1847,6 +1847,7 @@ redirect: /* GET requests */ if (ffurl_alloc(&rt->rtsp_hd, httpname, AVIO_FLAG_READ, &s->interrupt_callback) < 0) { + av_dict_free(&options); err = AVERROR(EIO); goto fail; } @@ -1863,6 +1864,7 @@ redirect: if (!rt->rtsp_hd->protocol_whitelist && s->protocol_whitelist) { rt->rtsp_hd->protocol_whitelist = av_strdup(s->protocol_whitelist); if (!rt->rtsp_hd->protocol_whitelist) { + av_dict_free(&options); err = AVERROR(ENOMEM); goto fail; } @@ -1878,6 +1880,7 @@ redirect: /* POST requests */ if (ffurl_alloc(&rt->rtsp_hd_out, httpname, AVIO_FLAG_WRITE, &s->interrupt_callback) < 0 ) { + av_dict_free(&options); err = AVERROR(EIO); goto fail; } -- 2.39.5 (Apple Git-154) _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2025-07-08 18:15 UTC|newest] Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-07-08 18:15 Marvin Scholz [this message] 2025-07-08 18:33 ` Kieran Kunhya via ffmpeg-devel
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20250708181532.60440-1-epirat07@gmail.com \ --to=epirat07-at-gmail.com@ffmpeg.org \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git