From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth
Date: Mon, 7 Jul 2025 16:58:33 +0200
Message-ID: <20250707145833.GG29660@pb2> (raw)
In-Reply-To: <aGup_8ypbz3QI1PC@phare.normalesup.org>
[-- Attachment #1.1: Type: text/plain, Size: 785 bytes --]
On Mon, Jul 07, 2025 at 01:05:35PM +0200, Nicolas George wrote:
> Michael Niedermayer (HE12025-07-07):
> > This variant is easy backportable but is concatdec specific
> >
> > Fixes: self_ref.ffconcat
> > Reported-by: Yuhao Jiang <danisjiang@gmail.com>
> > Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> > ---
> > libavformat/concatdec.c | 11 +++++++++++
> > 1 file changed, 11 insertions(+)
>
> What use case is it meant to fix?
not overflowing the stack from unlimited recursion
(on some platforms it will stop by exhausting file ids first but we should
not rely on that)
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Some Animals are More Equal Than Others. - George Orwell's book Animal Farm
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-07-07 14:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 10:31 [FFmpeg-devel] [PATCH 1/2] avformat: Add recursion limit Michael Niedermayer
2025-07-07 10:31 ` [FFmpeg-devel] [PATCH 2/2] avformat/concatdec: Check recursion depth Michael Niedermayer
2025-07-07 11:05 ` Nicolas George
2025-07-07 14:58 ` Michael Niedermayer [this message]
2025-07-07 15:09 ` Nicolas George
2025-07-07 20:07 ` Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250707145833.GG29660@pb2 \
--to=michael@niedermayer.cc \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git