Re: [FFmpeg-devel] [PATCH v4 1/3] avfilter/asrc_sinc: fix leak in config_input()

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v4 1/3] avfilter/asrc_sinc: fix leak in config_input()
Date: Sat, 5 Jul 2025 13:25:08 +0200
Message-ID: <20250705112508.GY29660@pb2> (raw)
In-Reply-To: <20250630150114.2152464-2-502024330056@smail.nju.edu.cn>

[-- Attachment #1.1: Type: text/plain, Size: 901 bytes --]

On Mon, Jun 30, 2025 at 11:01:12PM +0800, Lidong Yan wrote:
> In config_input(), fir_to_phase() allocates memory in h[longer], which
> would leak if av_calloc() to s->coeffs failed. lpf() allocates memory
> in h[0] and h[1], which would leak if fir_to_phase() failed. To fix
> this leak, add av_free(h[longer]) in as cleanup code, and replace
> return AVERROR* with goto cleanup to prevent from leaks.
> 
> Signed-off-by: Lidong Yan <502024330056@smail.nju.edu.cn>
> ---
>  libavfilter/asrc_sinc.c | 18 +++++++++++-------
>  1 file changed, 11 insertions(+), 7 deletions(-)

will apply

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".