* [FFmpeg-devel] [PATCH] fftools/cmdutils: don't try to load arguments from file if not needed
@ 2025-06-30 18:36 Kacper Michajłow
2025-07-05 11:24 ` Michael Niedermayer
0 siblings, 1 reply; 2+ messages in thread
From: Kacper Michajłow @ 2025-06-30 18:36 UTC (permalink / raw)
To: ffmpeg-devel; +Cc: Kacper Michajłow
CLI option parser checks if argument exists when needed, but in this
case only OPT_TYPE_BOOL where checked, so OPT_TYPE_FUNC without argument
where trying to load a file from `arg` which is NULL in this case.
Fixes crash on `ffmpeg -/version`
Fixes: 6d17991b7e1bf1a5d104c8a6261709f7e6640d97
Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
---
fftools/cmdutils.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/fftools/cmdutils.c b/fftools/cmdutils.c
index be21ed2c6c..e442935cae 100644
--- a/fftools/cmdutils.c
+++ b/fftools/cmdutils.c
@@ -255,9 +255,10 @@ static int write_option(void *optctx, const OptionDef *po, const char *opt,
if (*opt == '/') {
opt++;
- if (po->type == OPT_TYPE_BOOL) {
+ if (!opt_has_arg(po)) {
av_log(NULL, AV_LOG_FATAL,
- "Requested to load an argument from file for a bool option '%s'\n",
+ "Requested to load an argument from file for an option '%s'"
+ " which does not take an argument\n",
po->name);
return AVERROR(EINVAL);
}
--
2.45.1
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [FFmpeg-devel] [PATCH] fftools/cmdutils: don't try to load arguments from file if not needed
2025-06-30 18:36 [FFmpeg-devel] [PATCH] fftools/cmdutils: don't try to load arguments from file if not needed Kacper Michajłow
@ 2025-07-05 11:24 ` Michael Niedermayer
0 siblings, 0 replies; 2+ messages in thread
From: Michael Niedermayer @ 2025-07-05 11:24 UTC (permalink / raw)
To: FFmpeg development discussions and patches
[-- Attachment #1.1: Type: text/plain, Size: 764 bytes --]
On Mon, Jun 30, 2025 at 08:36:09PM +0200, Kacper Michajłow wrote:
> CLI option parser checks if argument exists when needed, but in this
> case only OPT_TYPE_BOOL where checked, so OPT_TYPE_FUNC without argument
> where trying to load a file from `arg` which is NULL in this case.
>
> Fixes crash on `ffmpeg -/version`
>
> Fixes: 6d17991b7e1bf1a5d104c8a6261709f7e6640d97
> Signed-off-by: Kacper Michajłow <kasper93@gmail.com>
> ---
> fftools/cmdutils.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
will apply
thx
[...]
--
Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB
Good people do not need laws to tell them to act responsibly, while bad
people will find a way around the laws. -- Plato
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
[-- Attachment #2: Type: text/plain, Size: 251 bytes --]
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-05 11:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-06-30 18:36 [FFmpeg-devel] [PATCH] fftools/cmdutils: don't try to load arguments from file if not needed Kacper Michajłow
2025-07-05 11:24 ` Michael Niedermayer
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git