Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov.c: Fix to allow custom udta tags through when export_all option specified.
Date: Sat, 5 Jul 2025 13:00:21 +0200
Message-ID: <20250705110021.GV29660@pb2> (raw)
In-Reply-To: <CABO4iZNcaSo5Yoox5GnA-zTPeetayZJryS_QU7zBFxKa-9CdjQ@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 1464 bytes --]

On Mon, Jun 30, 2025 at 03:33:43PM +1200, Ken McGaugh wrote:
> Sorry about that. I just attached the patch directly. Please let me know if
> this still doesn't work.
[...]

>  mov.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 8e1da8ae0d841c975de846882a43fe695f3ec4a2  0001-Updated-patch-allowing-custom-udta-atoms-to-pass-thr.patch
> From 3cce53b7fd4f0dd59872509f3e3c0ac0dc46d9ad Mon Sep 17 00:00:00 2001
> From: Ken McGaugh <ken@mcgaugh.co.uk>
> Date: Sun, 29 Jun 2025 09:37:20 +1200
> Subject: [PATCH] Updated patch allowing custom udta atoms to pass through
>  their values correctly when export_all option specified.
> 
> ---
>  libavformat/mov.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/libavformat/mov.c b/libavformat/mov.c
> index bd6b23466b..31ebcebca1 100644
> --- a/libavformat/mov.c
> +++ b/libavformat/mov.c
> @@ -484,7 +484,7 @@ retry:
>                  return ret;
>              }
>          } else return 0;
> -    } else if (atom.size > 4 && key && !c->itunes_metadata && !raw) {
> +    } else if (atom.size > 4 && (key || c->export_all) && !c->itunes_metadata && !raw) {

will apply

thx


[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Whats the most studid thing your enemy could do ? Blow himself up
Whats the most studid thing you could do ? Give up your rights and
freedom because your enemy blew himself up.


[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

      reply	other threads:[~2025-07-05 11:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-28  0:46 Ken McGaugh
2025-06-28  1:51 ` Baptiste Coudurier
2025-06-28  8:04   ` Ken McGaugh
2025-06-28 19:43     ` Baptiste Coudurier
2025-06-28 20:33       ` Ken McGaugh
2025-06-28 21:42         ` Ken McGaugh
2025-06-30  0:41           ` Michael Niedermayer
2025-06-30  3:33             ` Ken McGaugh
2025-07-05 11:00               ` Michael Niedermayer [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250705110021.GV29660@pb2 \
    --to=michael@niedermayer.cc \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git