From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 4DCA34DC64 for ; Fri, 4 Jul 2025 11:05:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id EA49C68F856; Fri, 4 Jul 2025 14:05:09 +0300 (EEST) Received: from relay16.mail.gandi.net (relay16.mail.gandi.net [217.70.178.236]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id A6AEC68F848 for ; Fri, 4 Jul 2025 14:05:02 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id 0593243890 for ; Fri, 4 Jul 2025 11:05:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=niedermayer.cc; s=gm1; t=1751627102; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=PSl/DlsTn7Shhx+vDYYEpDVEL56bUiaG9QyTqvmTVRc=; b=T8lr3cG9zJ+oHJaC51T/Pjm4OwWSfs8+Ab4+FhXJprfs3ZibF6wIP8ODyNvTZh0gfyxstJ ClX6cKNHCfYl6izh9DoCDKzavM9aYPngFBScRerZ9PEfq+kQMfTkDuM09th5sklWRNRk0s RdYglBZIshtJMEuUze+7cHsr0+Yxspa03+xcxH/pjcOEjkqKckfK68QoaBODnxOGSivcCu 8sMpB6IEeDU++hBRa1KHsih+n9nENSin2aNkRVJsU1R026E9tQgkY9Lf/Kx5HJVYiEnvfw 2/f41JoDKlHXK/eLk7CVO7z3If9HO79/gnIR+hRDMvGVyKfWuUxJONhkkbRjLg== Date: Fri, 4 Jul 2025 13:05:00 +0200 From: Michael Niedermayer To: FFmpeg development discussions and patches Message-ID: <20250704110500.GT29660@pb2> References: <67c3bd5d-4570-48d3-9957-60f788adfcb2@regaud-chapuy.fr> MIME-Version: 1.0 In-Reply-To: <67c3bd5d-4570-48d3-9957-60f788adfcb2@regaud-chapuy.fr> X-GND-State: clean X-GND-Score: -70 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgddvvdellecutefuodetggdotefrodftvfcurfhrohhfihhlvgemucfitefpfffkpdcuggftfghnshhusghstghrihgsvgenuceurghilhhouhhtmecufedtudenucesvcftvggtihhpihgvnhhtshculddquddttddmnegfrhhlucfvnfffucdlfedtmdenucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofhitghhrggvlhcupfhivgguvghrmhgrhigvrhcuoehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgeqnecuggftrfgrthhtvghrnhepieegkedtjeduffejhfetgeejtdegteetgfegtdfhjefgvefhteegkeejtddvhfevnecukfhppeeguddrieeirdeiiedrvddvjeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepihhnvghtpeeguddrieeirdeiiedrvddvjedphhgvlhhopehlohgtrghlhhhoshhtpdhmrghilhhfrhhomhepmhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtpdhnsggprhgtphhtthhopedupdhrtghpthhtohepfhhfmhhpvghgqdguvghvvghlsehffhhmphgvghdrohhrgh Subject: Re: [FFmpeg-devel] [PATCH] Macroblocks modes extraction X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: multipart/mixed; boundary="===============8884015243793703987==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============8884015243793703987== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="qbplyUqSo9TyEe1F" Content-Disposition: inline --qbplyUqSo9TyEe1F Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi On Wed, Jul 02, 2025 at 12:57:46PM +0200, Timothee wrote: > Hello, >=20 > I am working on a modification toextract per-macroblock prediction modes > (H.264 for now). The goal is to make this information available to > vf_codecview and print it in a log file (for now). >=20 > This are what I have added: >=20 > 1. >=20 > A new H264MBInfostruct holding the prediction modes. If existing data structures proof inadequate then a newly introduced data structure should allow storing macroblock info for an arbitrary square lattice of macroblocks and arbitrary rectangular subdivision tree. Or said differently, new API should support H264, H265, H266 We cannot have a incompatible data structure for each standard in public API >=20 > 2. >=20 > An AVBufferRef *mb_info_refis added to the H264Picturestruct to > store this data for each picture. >=20 > 3. >=20 > This buffer is allocated with av_buffer_allocz()in > alloc_picture()and its reference is released with > av_buffer_unref()in ff_h264_unref_picture(). >=20 > 4. >=20 > A new function, ff_h264_collect_mb_info(), is called after > macroblock decoding to populate the buffer. >=20 > 5. >=20 > In output_frame(), a new side data (AV_FRAME_DATA_H264_MB_INFO) > buffer is allocated, and the contents of srcp->mb_info_ref->dataare > copied into it. >=20 > 6. A new function to log the result in vf_codecview.c >=20 > This implementation results in a segmentation fault. I guess it is a race > condition, but I am struggling to fix it. missing entry in sd_props[] also make sure "make fate" works thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope --qbplyUqSo9TyEe1F Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaGe1WQAKCRBhHseHBAsP q41NAJ9RwHsJn4miP91uy0Z2Ne3NswwCaQCghqX/48KzMPmxMUpoGrEj+XVXpx8= =elS6 -----END PGP SIGNATURE----- --qbplyUqSo9TyEe1F-- --===============8884015243793703987== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============8884015243793703987==--