Re: [FFmpeg-devel] [PATCH] libavformat/usmdec: add support for HCA stream decryption

[Michael Niedermayer <michael@niedermayer.cc>]

[-- Attachment #1.1: Type: text/plain, Size: 1413 bytes --]

Hi

On Thu, Jul 03, 2025 at 03:28:32PM -0700, Pavel Roslyy wrote:
> Hello,
> 
> After experimenting, I think it would be a better idea to move the hca_*
> options into libavcodec/hcadec.c rather than duplicating them into the usm
> demuxer.  Before I try to submit patches that do this I have some questions.
> 
> 1) I plan on removing the hca_* options from libavformat/hca.c and placing
> them into libavcodec/hcadec.c.  Am I correct in assuming that this would be
> considered an API deprecation and would require doing deprecation guards in
> libavformat/hca.c?

If it could break a users script (by options disappearing) from a previous
release then it should be put under deprecation guards


> 
> 2) If considered an API deprecation, would it make sense to consolidate
> hca_lowkey and hca_highkey into a single hca_key option that takes 16 bits of
> hexadecimal string (like most other decryption key options) rather than
> keeping the options as integer hca_highkey / hca_lowkey in
> libavcodec/hcadec.c?

Thats a question for the people working with and using this feature

thx

[...]

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

If you fake or manipulate statistics in a paper in physics you will never
get a job again.
If you fake or manipulate statistics in a paper in medicin you will get
a job for life at the pharma industry.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]

[-- Attachment #2: Type: text/plain, Size: 251 bytes --]

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".