From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 061BF4FE42 for ; Thu, 3 Jul 2025 13:48:42 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 6E51768EAFC; Thu, 3 Jul 2025 16:48:37 +0300 (EEST) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id ADD8B68EA40 for ; Thu, 3 Jul 2025 16:48:31 +0300 (EEST) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-3121aed2435so7435435a91.2 for ; Thu, 03 Jul 2025 06:48:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751550509; x=1752155309; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6thiOW9noOiklQOW+z3qiHjDgTJdSRVybQdzU56mV7o=; b=dZKKnjZG0ZCeqRKtTLn4DgFZU1dMbIT6+DpWIXI5TMysFOPQZrZwko1m6GYMwzoKY4 I7x0IPJtQLzsYmg8xLoMcY1UVB4cix1l26c31eEyYgErIA4RN5EfmvsR/veXX0RSrHjQ KYD1H0piO6/qRoYa/ClavF7uRFqStbu+7LOIibJXLpdhp52ksKS+DkmLlnNzdPTNyGF0 XnhYKn5kah6JHm9XziYwAnVdM4yB69LjG75VoQYO4W1Y9QSmoBr5DpgTQeqhZl8iDVHr dWtYuNhH6y3Djqnc9E/U1JZWnESjx+FLdnD9Rl+NbbBmZ3tEorwg3ZsJhdn4WrnfZrvf 4MgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751550509; x=1752155309; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6thiOW9noOiklQOW+z3qiHjDgTJdSRVybQdzU56mV7o=; b=qSjIc76Rn8wixGoVzgR345SnKzdCm3WAyZGCU4MH0E3erB/OqvUFc2dKlPXScrBCQD eoCkh7OcW8aK1zON3Nw5jh6WhrUcnH4Hcri+MxTEMqLpZ3KGoc2Ht7c7alw4J9dDMaT/ M8cBWqlvob8/EPznd+hQuP9c0wwfhizAS0MXOh3F3Q1KQQUL+oyoadOdlfWYvqjsYNPD wm/723Dlr22YRreX6Ploxy4VbUu2fDIsGiA00LtdCtDMMYP27agbOtWdYhM5whJbVfua Zfob6PwOWxiVURlo4xzsBJcdoV0SZ4vmVXloUVC6XuyqIh2S2aA8YwAcEVXTTvyFJpko QsBg== X-Gm-Message-State: AOJu0YwwiwUdkIY9W0vaqO1nK47LA8bfG8HStgu20wPnVmLVxoGw5Ztg hIK/0kz8eij1wMt9njh8AKgK3k88ppnR1vK2IJWT7yaHCsgAUb07wdZVsp6KqIJe X-Gm-Gg: ASbGnctgDeWfGfsNXr4IbmizY2Fik+4QR54t3kA7MFkETgsHlGMiUpdl9eYjUzAcS7n X8EsOOQrtSakBqXhpAG8IogjJIGpJmsFlBTQ0UGj6otn049O3ArsL3Xl2QvtGyYYODh9xP6pGqA dgOxyw5tCF5PMflUNNTpQbHZyiRVvJa9qwtqWPo9XNnmO+7NlUPFlp4h+5TyfKA7RVsm0afCjdR /tQKkyQS6InwJrYjY0Y1j4lbVWIlR8wNJJLtxiNs4KxM6Dp9iEmUEgkERD4XvaSgMamIL4DGv51 QRqvktK1Xc3KTsLGwFNbIS7G X-Google-Smtp-Source: AGHT+IFwDyv/Pa378L9wn1Od78WRVSRlVlYCmr/LJIZ27sdzWjl7NMEiiUfZPvMvybmZVV2Nxa8tkQ== X-Received: by 2002:a17:90b:2d8d:b0:314:2939:efdc with SMTP id 98e67ed59e1d1-31a90b2ff4bmr9716796a91.13.1751550509384; Thu, 03 Jul 2025 06:48:29 -0700 (PDT) Received: from mfcc64.. ([182.4.133.33]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-31a9cc6ec94sm2365771a91.23.2025.07.03.06.48.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 03 Jul 2025 06:48:28 -0700 (PDT) From: Muhammad Faiz To: ffmpeg-devel@ffmpeg.org Date: Thu, 3 Jul 2025 20:47:58 +0700 Message-ID: <20250703134810.37587-1-mfcc64@gmail.com> X-Mailer: git-send-email 2.43.0 MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH] avfilter/avf_showcqt: fix unbounded index when copying to fft_data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Muhammad Faiz Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: When timeclamp and/or fps are low, j can be negative. Fix Ticket11640 --- libavfilter/avf_showcqt.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/avf_showcqt.c b/libavfilter/avf_showcqt.c index 8ff6ecb..8f9b782 100644 --- a/libavfilter/avf_showcqt.c +++ b/libavfilter/avf_showcqt.c @@ -1515,7 +1515,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *insamples) i = insamples->nb_samples - remaining; j = s->fft_len/2 + s->remaining_fill_max - s->remaining_fill; if (remaining >= s->remaining_fill) { - for (m = 0; m < s->remaining_fill; m++) { + for (m = FFMAX(0, -j); m < s->remaining_fill; m++) { s->fft_data[j+m].re = audio_data[2*(i+m)]; s->fft_data[j+m].im = audio_data[2*(i+m)+1]; } @@ -1544,7 +1544,7 @@ static int filter_frame(AVFilterLink *inlink, AVFrame *insamples) s->fft_data[m] = s->fft_data[m+step]; s->remaining_fill = step; } else { - for (m = 0; m < remaining; m++) { + for (m = FFMAX(0, -j); m < remaining; m++) { s->fft_data[j+m].re = audio_data[2*(i+m)]; s->fft_data[j+m].im = audio_data[2*(i+m)+1]; } -- 2.43.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".