[FFmpeg-devel] [PATCH 2/5] avcodec/smacker: Check input before allocation

From: Michael Niedermayer <michael@niedermayer.cc>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH 2/5] avcodec/smacker: Check input before allocation
Date: Thu,  3 Jul 2025 04:01:28 +0200
Message-ID: <20250703020131.2506428-2-michael@niedermayer.cc> (raw)
In-Reply-To: <20250703020131.2506428-1-michael@niedermayer.cc>

Fixes: Timeout
Fixes: 421650030/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SMACKAUD_fuzzer-6144441767493632

Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
---
 libavcodec/smacker.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/libavcodec/smacker.c b/libavcodec/smacker.c
index bd08bc7be28..99009bfd361 100644
--- a/libavcodec/smacker.c
+++ b/libavcodec/smacker.c
@@ -662,6 +662,10 @@ static int smka_decode_frame(AVCodecContext *avctx, AVFrame *frame,
         } else
             values[i] = h.entries[0].value;
     }
+    if (get_bits_left(&gb) < (stereo+1) * (bits+1) * 8) {
+        ret = AVERROR_INVALIDDATA;
+        goto error;
+    }
 
     if ((ret = ff_get_buffer(avctx, frame, 0)) < 0)
         return ret;
-- 
2.49.0

_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
