From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 3D8C24BBB1 for ; Wed, 2 Jul 2025 16:58:45 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 976A468D3E8; Wed, 2 Jul 2025 19:57:22 +0300 (EEST) Received: from btbn.de (btbn.de [144.76.60.213]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 7B19C68D215 for ; Wed, 2 Jul 2025 19:57:11 +0300 (EEST) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id A66B827FFCCB2; Wed, 02 Jul 2025 18:57:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1751475428; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eMbsyvU9I5X6MwC3LfqCQgMcL0Ua5PIAciAVaEDeGes=; b=ZobJwyxBgTXcyBBAkVe41m+xFLEPd7+N3jd6PAUMl9LaNx4JkkA8nxu2eNlH9rJsModXAq lNtnOrMt8ltMBAlDe04iQ7hK0DCmxYAazecrTyzZ10EqKDwdn7aWKBqvJ0W8jplvsvq4Tz KzJseoLNHtNVmmKRhKsCgmy/QcMUUrY3sytLPPsTTca/puKyueIXuY+5mYgkCx8GmgDRI+ ZVeYbaKpOugdNGy2QDB4z82doKCqdpMc2XBpHOIR3dy12toZMDV8iET9gq51JMN1NM7LKd qshXtl3+aaD4dXw9oFS+2uI4xpioYh2zzC2VMuisCYkNjRKHd/tDUibWExQNuQ== From: Timo Rothenpieler To: ffmpeg-devel@ffmpeg.org Date: Wed, 2 Jul 2025 18:56:42 +0200 Message-ID: <20250702165655.1325-15-timo@rothenpieler.org> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250702165655.1325-1-timo@rothenpieler.org> References: <20250702165655.1325-1-timo@rothenpieler.org> MIME-Version: 1.0 Subject: [FFmpeg-devel] [PATCH 14/18] avformat/tls: remove unused fingerprint option X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Timo Rothenpieler Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --- libavformat/tls.h | 5 +---- libavformat/tls_openssl.c | 4 +--- libavformat/whip.c | 1 - 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/libavformat/tls.h b/libavformat/tls.h index 2f381acc04..9285228657 100644 --- a/libavformat/tls.h +++ b/libavformat/tls.h @@ -66,12 +66,10 @@ typedef struct TLSShared { int use_external_udp; URLContext *udp; - /* The fingerprint of certificate, used in SDP offer. */ - char *fingerprint; - /* The certificate and private key content used for DTLS handshake */ char* cert_buf; char* key_buf; + /** * The size of RTP packet, should generally be set to MTU. * Note that pion requires a smaller value, for example, 1200. @@ -91,7 +89,6 @@ typedef struct TLSShared { {"http_proxy", "Set proxy to tunnel through", offsetof(pstruct, options_field . http_proxy), AV_OPT_TYPE_STRING, .flags = TLS_OPTFL }, \ {"use_external_udp", "Use external UDP from muxer or demuxer", offsetof(pstruct, options_field . use_external_udp), AV_OPT_TYPE_INT, { .i64 = 0}, 0, 1, .flags = TLS_OPTFL }, \ {"mtu", "Maximum Transmission Unit", offsetof(pstruct, options_field . mtu), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, .flags = TLS_OPTFL}, \ - {"fingerprint", "The optional fingerprint for DTLS", offsetof(pstruct, options_field . fingerprint), AV_OPT_TYPE_STRING, .flags = TLS_OPTFL}, \ {"cert_buf", "The optional certificate buffer for DTLS", offsetof(pstruct, options_field . cert_buf), AV_OPT_TYPE_STRING, .flags = TLS_OPTFL}, \ {"key_buf", "The optional private key buffer for DTLS", offsetof(pstruct, options_field . key_buf), AV_OPT_TYPE_STRING, .flags = TLS_OPTFL} diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index d83fe602d5..2049eb021b 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -1013,8 +1013,7 @@ static int dtls_start(URLContext *h, const char *url, int flags, AVDictionary ** } } - av_log(p, AV_LOG_VERBOSE, "TLS: Setup ok, MTU=%d, fingerprint %s\n", - p->tls_shared.mtu, p->tls_shared.fingerprint); + av_log(p, AV_LOG_VERBOSE, "TLS: Setup ok, MTU=%d\n", p->tls_shared.mtu); ret = 0; fail: @@ -1032,7 +1031,6 @@ static av_cold int dtls_close(URLContext *h) TLSContext *ctx = h->priv_data; SSL_free(ctx->ssl); SSL_CTX_free(ctx->ctx); - av_freep(&ctx->tls_shared.fingerprint); av_freep(&ctx->tls_shared.cert_buf); av_freep(&ctx->tls_shared.key_buf); EVP_PKEY_free(ctx->pkey); diff --git a/libavformat/whip.c b/libavformat/whip.c index 71c667cd31..602a4432bd 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1297,7 +1297,6 @@ next_packet: av_dict_set(&opts, "key_file", whip->key_file, 0); } else av_dict_set(&opts, "key_buf", whip->key_buf, 0); - av_dict_set(&opts, "fingerprint", whip->dtls_fingerprint, 0); av_dict_set_int(&opts, "use_external_udp", 1, 0); av_dict_set_int(&opts, "listen", 1, 0); /* If got the first binding response, start DTLS handshake. */ -- 2.49.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".