From: Timo Rothenpieler <timo@rothenpieler.org> To: ffmpeg-devel@ffmpeg.org Cc: Timo Rothenpieler <timo@rothenpieler.org> Subject: [FFmpeg-devel] [PATCH 14/18] avformat/tls: remove unused fingerprint option Date: Wed, 2 Jul 2025 18:56:42 +0200 Message-ID: <20250702165655.1325-15-timo@rothenpieler.org> (raw) In-Reply-To: <20250702165655.1325-1-timo@rothenpieler.org> --- libavformat/tls.h | 5 +---- libavformat/tls_openssl.c | 4 +--- libavformat/whip.c | 1 - 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/libavformat/tls.h b/libavformat/tls.h index 2f381acc04..9285228657 100644 --- a/libavformat/tls.h +++ b/libavformat/tls.h @@ -66,12 +66,10 @@ typedef struct TLSShared { int use_external_udp; URLContext *udp; - /* The fingerprint of certificate, used in SDP offer. */ - char *fingerprint; - /* The certificate and private key content used for DTLS handshake */ char* cert_buf; char* key_buf; + /** * The size of RTP packet, should generally be set to MTU. * Note that pion requires a smaller value, for example, 1200. @@ -91,7 +89,6 @@ typedef struct TLSShared { {"http_proxy", "Set proxy to tunnel through", offsetof(pstruct, options_field . http_proxy), AV_OPT_TYPE_STRING, .flags = TLS_OPTFL }, \ {"use_external_udp", "Use external UDP from muxer or demuxer", offsetof(pstruct, options_field . use_external_udp), AV_OPT_TYPE_INT, { .i64 = 0}, 0, 1, .flags = TLS_OPTFL }, \ {"mtu", "Maximum Transmission Unit", offsetof(pstruct, options_field . mtu), AV_OPT_TYPE_INT, { .i64 = 0 }, 0, INT_MAX, .flags = TLS_OPTFL}, \ - {"fingerprint", "The optional fingerprint for DTLS", offsetof(pstruct, options_field . fingerprint), AV_OPT_TYPE_STRING, .flags = TLS_OPTFL}, \ {"cert_buf", "The optional certificate buffer for DTLS", offsetof(pstruct, options_field . cert_buf), AV_OPT_TYPE_STRING, .flags = TLS_OPTFL}, \ {"key_buf", "The optional private key buffer for DTLS", offsetof(pstruct, options_field . key_buf), AV_OPT_TYPE_STRING, .flags = TLS_OPTFL} diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index d83fe602d5..2049eb021b 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -1013,8 +1013,7 @@ static int dtls_start(URLContext *h, const char *url, int flags, AVDictionary ** } } - av_log(p, AV_LOG_VERBOSE, "TLS: Setup ok, MTU=%d, fingerprint %s\n", - p->tls_shared.mtu, p->tls_shared.fingerprint); + av_log(p, AV_LOG_VERBOSE, "TLS: Setup ok, MTU=%d\n", p->tls_shared.mtu); ret = 0; fail: @@ -1032,7 +1031,6 @@ static av_cold int dtls_close(URLContext *h) TLSContext *ctx = h->priv_data; SSL_free(ctx->ssl); SSL_CTX_free(ctx->ctx); - av_freep(&ctx->tls_shared.fingerprint); av_freep(&ctx->tls_shared.cert_buf); av_freep(&ctx->tls_shared.key_buf); EVP_PKEY_free(ctx->pkey); diff --git a/libavformat/whip.c b/libavformat/whip.c index 71c667cd31..602a4432bd 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -1297,7 +1297,6 @@ next_packet: av_dict_set(&opts, "key_file", whip->key_file, 0); } else av_dict_set(&opts, "key_buf", whip->key_buf, 0); - av_dict_set(&opts, "fingerprint", whip->dtls_fingerprint, 0); av_dict_set_int(&opts, "use_external_udp", 1, 0); av_dict_set_int(&opts, "listen", 1, 0); /* If got the first binding response, start DTLS handshake. */ -- 2.49.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2025-07-02 16:58 UTC|newest] Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top 2025-07-02 16:56 [FFmpeg-devel] [PATCH 00/18] WHIP + TLS + UDP fixes and SChannel DTLS support Timo Rothenpieler 2025-07-02 16:56 ` [FFmpeg-devel] [PATCH 01/18] avformat/Makefile: don't hardcode openssl for whip muxer Timo Rothenpieler 2025-07-03 14:00 ` Steven Liu 2025-07-02 16:56 ` [FFmpeg-devel] [PATCH 02/18] avformat/whip: use av_dict_set_int for int Timo Rothenpieler 2025-07-03 14:01 ` Steven Liu 2025-07-02 16:56 ` [FFmpeg-devel] [PATCH 03/18] avformat/whip: don't leak options dict Timo Rothenpieler 2025-07-03 14:02 ` Steven Liu 2025-07-02 16:56 ` [FFmpeg-devel] [PATCH 04/18] avformat/whip: remove redundant WHIP: prefix from all logging Timo Rothenpieler 2025-07-03 14:02 ` Steven Liu 2025-07-02 16:56 ` [FFmpeg-devel] [PATCH 05/18] avformat/whip: fix format string for printing size_t Timo Rothenpieler 2025-07-03 14:03 ` Steven Liu 2025-07-02 16:56 ` [FFmpeg-devel] [PATCH 06/18] avformat/tls: use non protocol specific error message Timo Rothenpieler 2025-07-03 14:03 ` Steven Liu 2025-07-02 16:56 ` [FFmpeg-devel] [PATCH 07/18] avformat/tls: don't use http_proxy for udp sockets Timo Rothenpieler 2025-07-03 14:04 ` Steven Liu 2025-07-02 16:56 ` [FFmpeg-devel] [PATCH 08/18] avformat/tls: move openssl specific init out of generic code Timo Rothenpieler 2025-07-03 1:07 ` Jack Lau 2025-07-03 14:24 ` Timo Rothenpieler 2025-07-03 15:22 ` Jack Lau 2025-07-03 16:41 ` Timo Rothenpieler 2025-07-02 16:56 ` [FFmpeg-devel] [PATCH 09/18] avformat/udp: don't override 0 localport Timo Rothenpieler 2025-07-03 14:05 ` Steven Liu 2025-07-02 16:56 ` [FFmpeg-devel] [PATCH 10/18] avformat/tls: fix udp init Timo Rothenpieler 2025-07-03 14:06 ` Steven Liu 2025-07-02 16:56 ` [FFmpeg-devel] [PATCH 11/18] avformat/udp: make recv addr of each packet available Timo Rothenpieler 2025-07-02 16:56 ` [FFmpeg-devel] [PATCH 12/18] avformat/udp: separate rx and tx fifo Timo Rothenpieler 2025-07-03 14:07 ` Steven Liu 2025-07-02 16:56 ` [FFmpeg-devel] [PATCH 13/18] avformat/udp: add function to set remote address directly Timo Rothenpieler 2025-07-02 16:56 ` Timo Rothenpieler [this message] 2025-07-02 16:56 ` [FFmpeg-devel] [PATCH 15/18] avformat/tls: clean up new whip options Timo Rothenpieler 2025-07-02 16:56 ` [FFmpeg-devel] [PATCH 16/18] avformat/tls: make passing an external socket universal Timo Rothenpieler 2025-07-02 16:56 ` [FFmpeg-devel] [PATCH 17/18] avformat/tls_openssl: use existing context handle Timo Rothenpieler 2025-07-02 16:56 ` [FFmpeg-devel] [PATCH 18/18] avformat/tls_schannel: add DTLS support Timo Rothenpieler
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20250702165655.1325-15-timo@rothenpieler.org \ --to=timo@rothenpieler.org \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git