From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 24BE04D867 for ; Wed, 2 Jul 2025 12:01:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 65E5268D078; Wed, 2 Jul 2025 15:00:26 +0300 (EEST) Received: from mail-pj1-f53.google.com (mail-pj1-f53.google.com [209.85.216.53]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 1DD6D68CFFE for ; Wed, 2 Jul 2025 15:00:20 +0300 (EEST) Received: by mail-pj1-f53.google.com with SMTP id 98e67ed59e1d1-315b0050bb5so3792341a91.0 for ; Wed, 02 Jul 2025 05:00:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751457618; x=1752062418; darn=ffmpeg.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PKaGNUVjiWxf1BWcS0NVXHOLO98xx0+j1YAnhCZnaUo=; b=Ob4LgRQSGuFCxXKUeWE3OKxV/2Yl2/dcxgp7gvSSxSfjwuC1JnYVj37txzOCjsUt9S MvOuBLAHbRBeN4henDwqaxjTrZ2qr7UcaYQRKeKKzUdjRdZxrWkaIi9qPg4xUhjj9K5T cSVvFKipWU8wNht+k3pMZpr97zGgHIB4ih11IWjlO1MpAX6ybF7wvCBpLlbmxHrsvA0j KtHbUouzYdBuTZBOdbawYZC4Nvd1U9vM3HmTsBZnT3JZinF9yNAyOOUMsuVnBBQsSBkM 6CFvqybmq3hEpLALC3/v60U5y20dARwXxn+ybg+J8s+AitUfRrgyGaAl57ko8utHqoQy tXyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751457618; x=1752062418; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PKaGNUVjiWxf1BWcS0NVXHOLO98xx0+j1YAnhCZnaUo=; b=kieMof+KKNQ4pHHpaIws5iNLTTEEikemDtLSKv1IiNYtS2rhZvYSnwjmVQEGM3qlpv HiYb6/JP1X8xB0imzddDzSUO3gk86DesuUnlio9im/Ruuyz3tFhkZ5pkSRWWe5NqBNZw CFS7Jt0vBdrGlCS3WGavx3nMI+WmaEGbYDWWSHtdOabwKTzVj6K5RbF9/5guNNozz5oz 8mOSUTGMAE0wUFbRKEG7XoTbQQsawaVGbsqKJnX7C8E+wFXkkmxADdkbzL9XjY7DuGK1 dNAbU5a8hHcXxVpkHNpcSI0D214iDTNMNusj5h4gESe5EgyDC026JJ7+OZIRjWJxqGF4 ksZg== X-Gm-Message-State: AOJu0Yx4RHRaAHPkS1lypQUkBWjHgX/X3yWtYXI0ARwQz+pHXGDzf8XG Tgrr9kXWVUYqgm34W3nj9qmMWKKPAMOVfqnWOb3f5kPkJ+CEY7riQRIB28CA2fpKAlCeLQ== X-Gm-Gg: ASbGncuJeBFX02bECn7mqD9LC1bx1FRygCBL0s8zxmE2HBVwMSGztmPzgBbNv1hFXPm WlrCfpyg7kHhihGIJaWI2TcjhyAKvcZ5i0vm6mhBsuZz/KvYFloDcdVIub3QZLDpBniEE/bqTXl fEX7eJwpwvs70rUvpyvNj9TQC6xKWS2XXRDF9prFTtn3r1ai/O3t7ntAcuxI3ngQfSRnPhoPjeT /cqrNjMAhJrq8oKznyYTK8Y0RaeC6nXu6QCZixwRDs1NbH2zkaCHbGWDXeOj10K2gOqSttlqWCt UiVt8v+/8G840DRGcbckQbnfP+T4Uqta2Eo0ts4WEFpHOYUBVwrbG3kFJUV1V5An5w== X-Google-Smtp-Source: AGHT+IEFKxlNR+OO7xCsKuZ7ZnvtoP1tjysbLG9ZUQtvKzAgmOET55dpGnacbsmnwMUMUkPYfd7X3w== X-Received: by 2002:a17:90b:1a89:b0:313:f6fa:5bc6 with SMTP id 98e67ed59e1d1-31a90c344camr4144474a91.20.1751457617501; Wed, 02 Jul 2025 05:00:17 -0700 (PDT) Received: from localhost.localdomain ([5.34.218.79]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-23acb39b928sm127504185ad.111.2025.07.02.05.00.16 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Wed, 02 Jul 2025 05:00:17 -0700 (PDT) From: Jack Lau X-Google-Original-From: Jack Lau To: ffmpeg-devel@ffmpeg.org Date: Wed, 2 Jul 2025 19:59:53 +0800 Message-ID: <20250702115955.33922-5-jacklau1222@qq.com> X-Mailer: git-send-email 2.49.0 In-Reply-To: <20250702115955.33922-1-jacklau1222@qq.com> References: <20250702115955.33922-1-jacklau1222@qq.com> MIME-Version: 1.0 X-Unsent: 1 Subject: [FFmpeg-devel] [PATCH v2 4/6] WHIP: X509 cert serial number should be positive. X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: winlin , Jack Lau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: From: winlin See RFC5280 4.1.2.2 Co-authored-by: winlin Signed-off-by: Jack Lau --- libavformat/tls_openssl.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 2a3905891d..4733faec9c 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -316,7 +316,8 @@ static int openssl_gen_certificate(EVP_PKEY *pkey, X509 **cert, char **fingerpri goto enomem_end; } - serial = (int)av_get_random_seed(); + // According to RFC5280 4.1.2.2, The serial number MUST be a positive integer + serial = (int)(av_get_random_seed() & 0x7FFFFFFF); if (ASN1_INTEGER_set(X509_get_serialNumber(*cert), serial) != 1) { av_log(NULL, AV_LOG_ERROR, "TLS: Failed to set serial, %s\n", ERR_error_string(ERR_get_error(), NULL)); goto einval_end; -- 2.49.0 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".